From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36768 invoked by alias); 29 Sep 2017 14:03:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36167 invoked by uid 89); 29 Sep 2017 14:03:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1117, H*M:363c, our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Sep 2017 14:03:31 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9F4B24E341 for ; Fri, 29 Sep 2017 14:03:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9F4B24E341 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id F150F9412C; Fri, 29 Sep 2017 14:03:22 +0000 (UTC) Subject: Re: [PATCH v3 5/5] Extend "set cwd" to work on gdbserver To: Sergio Durigan Junior References: <20170912042325.14927-1-sergiodj@redhat.com> <20170921225926.23132-1-sergiodj@redhat.com> <20170921225926.23132-6-sergiodj@redhat.com> <877ewjak4d.fsf@redhat.com> Cc: GDB Patches From: Pedro Alves Message-ID: Date: Fri, 29 Sep 2017 14:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <877ewjak4d.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00906.txt.bz2 On 09/27/2017 10:48 PM, Sergio Durigan Junior wrote: >> note: >> s/when/if/. >> s/@code/@kdb > > It's @kbd (from "keyboard"). But I know, our muscle memory wants us to > type "db" :-P. ;-) > > Even though I slightly disagree here (commands are not keybindings), I > found that this is indeed what GDB uses. Anyway, using @kbd now. See discussion starting here: https://sourceware.org/ml/gdb-patches/2017-06/msg00592.html > > Not in this specific version, no. This was something decided *after* I > had sent this version. In my local tree I have code implementing the > "clear up" behaviour, and I'll add a test for that as well. OK, thanks. Sorry I got confused. >> There are many other boards that set use_gdb_stub, not just >> native-gdbserver. Other testcases say: >> >> untested "skipping tests due to use_gdb_stub" > > Hm, OK. > > Does this look correct now, though? I don't know; I'll take a look at v4. We may still need is_remote checks depending on whether the tests have assumptions about build==host or host==target. Thanks, Pedro Alves