From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iLTMDLBNzWIuPhEAWB0awg (envelope-from ) for ; Tue, 12 Jul 2022 06:32:16 -0400 Received: by simark.ca (Postfix, from userid 112) id 249EA1E5EA; Tue, 12 Jul 2022 06:32:16 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Xzf4/KDd; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AC5B41E21F for ; Tue, 12 Jul 2022 06:32:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 50B873858295 for ; Tue, 12 Jul 2022 10:32:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50B873858295 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1657621935; bh=OqIrdi+tlXTSZ0VWoGheX7Hj4AS8lUhgr31QEOKBt1w=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Xzf4/KDdegr7M2aQYy6GzURaRZesMBaiiMINCrXRvUondXi9IV0hpJI3rksLd8T8M a1oQowImiPqnXwjDwrbtyh88Vtcq0WRZ8gfkf+pT3IBnIZrtmX/Xg+tPnqUDbVvmRA 7WlRJsJd8DHhHgY7yZqxXfHTihL4VUGYbmsODtTs= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 337093858C53 for ; Tue, 12 Jul 2022 10:31:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 337093858C53 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5173B22790 for ; Tue, 12 Jul 2022 10:31:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3FDBC13A94 for ; Tue, 12 Jul 2022 10:31:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Et5jDphNzWK3bQAAMHmgww (envelope-from ) for ; Tue, 12 Jul 2022 10:31:52 +0000 Content-Type: multipart/mixed; boundary="------------zyVTuM7g9gP0SiFm5jylYGYB" Message-ID: Date: Tue, 12 Jul 2022 12:31:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH][gdb] Add tsan-suppressions.txt Content-Language: en-US To: gdb-patches@sourceware.org References: <20220711100825.GA15997@delia.home> In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This is a multi-part message in MIME format. --------------zyVTuM7g9gP0SiFm5jylYGYB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/12/22 10:39, Tom de Vries wrote: > On 7/11/22 12:08, Tom de Vries wrote: >> Hi, >> >> Add a new file tsan-suppressions.txt, to suppress the "unlock unlocked >> mutex" >> problem in ncurses, filed in PR29328. >> >> For now, one needs to specify it manually using something like: >> ... >> $ export TSAN_OPTIONS=suppressions=$(pwd >> -P)/src/gdb/tsan-suppressions.txt >> ... >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29328 >> >> Any comments? >> > > I just found that we already set ASAN_OPTIONS in lib/gdb.exp, so I've > added this TSAN_OPTIONS setting alongside. I furthermore realized that suppression files are not cumulative, so if we have suppressions=a.txt:suppressions=b.txt then only b.txt is used. This would mean we ignore any user-specified suppression files, which may contains more suppressions for whatever reason. So I've updated the patch to only add the suppressions if the user didn't already do that. Thanks, - Tom --------------zyVTuM7g9gP0SiFm5jylYGYB Content-Type: text/x-patch; charset=UTF-8; name="0006-gdb-Add-tsan-suppressions.txt.patch" Content-Disposition: attachment; filename="0006-gdb-Add-tsan-suppressions.txt.patch" Content-Transfer-Encoding: base64 W2dkYl0gQWRkIHRzYW4tc3VwcHJlc3Npb25zLnR4dAoKQWRkIGEgbmV3IGZpbGUgdHNhbi1z dXBwcmVzc2lvbnMudHh0LCB0byBzdXBwcmVzcyB0aGUgInVubG9jayB1bmxvY2tlZCBtdXRl eCIKcHJvYmxlbSBpbiBuY3Vyc2VzLCBmaWxlZCBpbiBQUjI5MzI4LgoKVGhlIGZpbGUgaXMg YWRkZWQgdG8gdGhlIFRTQU5fT1BUSU9OUyBpbiBsaWIvZ2RiLmV4cC4KCkJ1ZzogaHR0cHM6 Ly9zb3VyY2V3YXJlLm9yZy9idWd6aWxsYS9zaG93X2J1Zy5jZ2k/aWQ9MjkzMjgKCi0tLQog Z2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cCB8IDI2ICsrKysrKysrKysrKysrKysrKysrKysr KysrCiBnZGIvdHNhbi1zdXBwcmVzc2lvbnMudHh0IHwgMTggKysrKysrKysrKysrKysrKysr CiAyIGZpbGVzIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nZGIv dGVzdHN1aXRlL2xpYi9nZGIuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cAppbmRl eCBhMjliOGY5NDdjNC4uNjk4ZGQxNDUwNGUgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUv bGliL2dkYi5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cApAQCAtMzIsNiAr MzIsMzIgQEAgaWYgeyR0b29sID09ICIifSB7CiAjICh3aGljaCB3aWxsIGFmZmVjdCBhbnkg c3Bhd25lZCBzdWItcHJvY2VzcykgdG8gYXZvaWQgdGhpcy4KIGFwcGVuZCA6OmVudihBU0FO X09QVElPTlMpICIsZGV0ZWN0X2xlYWtzPTAiCiAKKyMgQWRkIFZBUl9JRD1WQUwgdG8gRU5W X1ZBUiwgdW5sZXNzIEVOVl9WQVIgYWxyZWFkeSBjb250YWlucyBhIFZBUl9JRCBzZXR0aW5n LgorCitwcm9jIHNldF9zYW5pdGl6ZXJfZGVmYXVsdCB7IGVudl92YXIgdmFyX2lkIHZhbCB9 IHsKKyAgICBnbG9iYWwgZW52CisKKyAgICBpZiB7ICFbaW5mbyBleGlzdHMgZW52KCRlbnZf dmFyKSBdCisJIHx8ICRlbnYoJGVudl92YXIpID09ICIiIH0geworCSMgU2V0IHZhcl9pZCAo ZW52X3ZhciBub24tZXhpc3RpbmcgLyBlbXB0eSBjYXNlKS4KKwlhcHBlbmQgZW52KCRlbnZf dmFyKSAkdmFyX2lkPSR2YWwKKwlyZXR1cm4KKyAgICB9CisKKyAgICBpZiB7IFtyZWdleHAg JHZhcl9pZD0gJGVudigkZW52X3ZhcildIH0geworCSMgRG9uJ3Qgc2V0IHZhcl9pZC4gIEl0 J3MgYWxyZWFkeSBzZXQgYnkgdGhlIHVzZXIsIGxlYXZlIGFzIGlzLgorCSMgTm90ZSB0aGF0 IHdlIGNvdWxkIHByb2JhYmx5IGdldCB0aGUgc2FtZSByZXN1bHQgYnkgdW5jb25kaXRpb25h bGx5CisJIyBwcmVwZW5kaW5nIGl0LCBidXQgdGhpcyB3YXkgaXMgbGVzcyBsaWtlbHkgdG8g Y2F1c2UgY29uZnVzaW9uLgorCXJldHVybgorICAgIH0KKworICAgICMgU2V0IHZhcl9pZCAo ZW52X3ZhciBub3QgZW1wdHkgY2FzZSkuCisgICAgYXBwZW5kIGVudigkZW52X3ZhcikgOiAk dmFyX2lkPSR2YWwKK30KKworc2V0X3Nhbml0aXplcl9kZWZhdWx0IFRTQU5fT1BUSU9OUyBz dXBwcmVzc2lvbnMgXAorICAgICRzcmNkaXIvLi4vdHNhbi1zdXBwcmVzc2lvbnMudHh0CisK ICMgTGlzdCBvZiBwcm9jcyB0byBydW4gaW4gZ2RiX2ZpbmlzaC4KIHNldCBnZGJfZmluaXNo X2hvb2tzIFtsaXN0XQogCmRpZmYgLS1naXQgYS9nZGIvdHNhbi1zdXBwcmVzc2lvbnMudHh0 IGIvZ2RiL3RzYW4tc3VwcHJlc3Npb25zLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMC4uNWYxZTVkYzdlYTcKLS0tIC9kZXYvbnVsbAorKysgYi9nZGIvdHNh bi1zdXBwcmVzc2lvbnMudHh0CkBAIC0wLDAgKzEsMTggQEAKKyMgQ29weXJpZ2h0IChDKSAy MDIyIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorIyBUaGlzIHByb2dyYW0gaXMg ZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQor IyBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNl IGFzIHB1Ymxpc2hlZCBieQorIyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRo ZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgorIyAoYXQgeW91ciBvcHRpb24pIGFu eSBsYXRlciB2ZXJzaW9uLgorIworIyBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4g dGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyMgYnV0IFdJVEhPVVQgQU5ZIFdB UlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyMgTUVSQ0hB TlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRo ZQorIyBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorIwor IyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQ dWJsaWMgTGljZW5zZQorIyBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5vdCwgc2Vl IDxodHRwOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworIyBQcm9ibGVtIGluIG5jdXJz ZXMsIHNlZToKKyMgLSBodHRwczovL3NvdXJjZXdhcmUub3JnL2J1Z3ppbGxhL3Nob3dfYnVn LmNnaT9pZD0yOTMyOC4KKyMgLSBodHRwczovL2xpc3RzLmdudS5vcmcvYXJjaGl2ZS9odG1s L2J1Zy1uY3Vyc2VzLzIwMjItMDcvbXNnMDAwMDIuaHRtbAorbXV0ZXg6bmV3dGVybQo= --------------zyVTuM7g9gP0SiFm5jylYGYB--