From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA v2 16/17] Convert dwarf_expr_context_funcs to methods
Date: Fri, 28 Oct 2016 13:36:00 -0000 [thread overview]
Message-ID: <b0005a6d-4f0f-ca54-e0c1-18cad7fc7656@redhat.com> (raw)
In-Reply-To: <87a8dyhetz.fsf@tromey.com>
On 10/20/2016 10:48 PM, Tom Tromey wrote:
> Pedro> Should we remove the parens throughout?
>
> Tom> I made this change.
>
> Here's the updated version of this patch.
> It also fixes some "CTX" comments.
Unfortunately, this caused regressions:
https://sourceware.org/ml/gdb-testers/2016-q4/msg01382.html
*** Diff to previous build ***
============================
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: entry_reference: bt
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: entry_reference: p regparam
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: entry_reference: p regparam@entry
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: entry_reference: p ®param@entry
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: tailcall: bt
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: tailcall: p i
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: tailcall: p i@entry
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: tailcall: p j
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: tailcall: p j@entry
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: ambiguous: bt
PASS -> FAIL: gdb.arch/amd64-entry-value.exp: self: bt
PASS -> FAIL: gdb.arch/amd64-tailcall-noret.exp: bt
PASS -> FAIL: gdb.dwarf2/dw2-op-call.exp: p arraycallnoloc
PASS -> FAIL: gdb.dwarf2/typeddwarf.exp: check value of w at typeddwarf.c:29
PASS -> FAIL: gdb.dwarf2/typeddwarf.exp: check value of x at typeddwarf.c:29
PASS -> FAIL: gdb.dwarf2/typeddwarf.exp: check value of y at typeddwarf.c:29
PASS -> FAIL: gdb.dwarf2/typeddwarf.exp: check value of w at typeddwarf.c:53
PASS -> FAIL: gdb.dwarf2/typeddwarf.exp: check value of x at typeddwarf.c:53
PASS -> FAIL: gdb.dwarf2/typeddwarf.exp: check value of y at typeddwarf.c:53
============================
I've confirmed that going back to the commit before
192ca6d8eac4 ("Convert dwarf_expr_context_funcs to methods"),
the FAILs disappear.
Comparing before/after logs, I see:
~~~
-#0 reference (regparam=@0x7fffffffd344: 21, regparam@entry=@0x7fffffffd344: 1, nodataparam=@0x60202c: 22, r3=r3@entry=3, r4=r4@entry=4, r5=r5@entry=5, r6=r6@entry=6, stackparam1=@0x7fffffffd348: 31, stackparam2=@0x7fffffffd34c: 32) at gdb.arch/amd64-entry-value.cc:155
+#0 reference (regparam=@0x7fffffffcf14: 32767, regparam@entry=@0x7fffffffcf54: 1, nodataparam=@0x60202c: 22, r3=r3@entry=3, r4=r4@entry=4, r5=r5@entry=5, r6=r6@entry=6, stackparam1=@0x7fffffffcf58: 31, stackparam2=@0x7fffffffcf5c: 32) at gdb.arch/amd64-entry-value.cc:155
#1 0x00000000004005d0 in main () at gdb.arch/amd64-entry-value.cc:222
-(gdb) PASS: gdb.arch/amd64-entry-value.exp: entry_reference: bt
+(gdb) FAIL: gdb.arch/amd64-entry-value.exp: entry_reference: bt
-$14 = (int &) @0x7fffffffd344: 21
-(gdb) PASS: gdb.arch/amd64-entry-value.exp: entry_reference: p regparam
+$14 = (int &) @0x7fffffffcf14: 32767
+(gdb) FAIL: gdb.arch/amd64-entry-value.exp: entry_reference: p regparam
~~~
"32767" looks a lot like maybe some unitialized field in one of the classes.
~~~
-Breakpoint 2, d (i=71, i@entry=70, j=73.5, j@entry=72.5) at gdb.arch/amd64-entry-value.cc:34
+Breakpoint 2, d (i=<error reading variable: DWARF-2 expression error: Loop detected (257).>, j=<error reading variable: DWARF-2 expression error: Loop detected (257).>) at
~~~
Many instances of that loop error, actually.
~~~
-$26 = 1
-(gdb) PASS: gdb.dwarf2/typeddwarf.exp: check value of w at typeddwarf.c:53
+DW_OP_GNU_const_type has different sizes for type and data
+(gdb) FAIL: gdb.dwarf2/typeddwarf.exp: check value of w at typeddwarf.c:53
~~~
~~~
p arraycallnoloc
-Asked for position 0 of stack, stack only has 0 elements on it.
-(gdb) PASS: gdb.dwarf2/dw2-op-call.exp: p arraycallnoloc
-testcase /home/pedro/gdb/mygit/cxx-convertion/src/gdb/testsuite/gdb.dwarf2/dw2-op-call.exp completed in 1 seconds
+DW_OP_GNU_implicit_pointer is invalid in this context
+(gdb) FAIL: gdb.dwarf2/dw2-op-call.exp: p arraycallnoloc
+testcase /home/pedro/gdb/mygit/cxx-convertion/src/gdb/testsuite/gdb.dwarf2/dw2-op-call.exp completed in 0 seconds
~~~
Could you take a look? Maybe it'll be obvious to you what
the problem is.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-10-28 13:36 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 21:11 [RFA v2 00/17] more C++ Tom Tromey
2016-10-13 21:11 ` [RFA v2 04/17] Introduce minimal_symbol_reader Tom Tromey
2016-10-13 22:20 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 11/17] Use gdb::unique_ptr in elf_read_minimal_symbols Tom Tromey
2016-10-13 22:44 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 07/17] Remove make_cleanup_restore_current_ui Tom Tromey
2016-10-13 22:37 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 10/17] Replace two xmallocs with unique_ptr Tom Tromey
2016-10-13 22:44 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 12/17] Remove make_cleanup_restore_current_uiout Tom Tromey
2016-10-13 22:49 ` Pedro Alves
2016-10-14 21:30 ` Tom Tromey
2016-10-20 21:46 ` Tom Tromey
2016-10-20 21:57 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 05/17] Change minimal_symbol_reader to store objfile Tom Tromey
2016-10-13 22:21 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 15/17] Convert DWARF expr functions to methods Tom Tromey
2016-10-13 23:01 ` Pedro Alves
2016-10-20 21:47 ` Tom Tromey
2016-10-20 22:01 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 02/17] Use scoped_restore for ui_file Tom Tromey
2016-10-13 22:07 ` Pedro Alves
2016-10-14 21:33 ` Tom Tromey
2016-10-13 21:11 ` [RFA v2 16/17] Convert dwarf_expr_context_funcs to methods Tom Tromey
2016-10-13 23:05 ` Pedro Alves
2016-10-18 2:50 ` Tom Tromey
2016-10-18 10:51 ` Pedro Alves
2016-10-18 14:55 ` Tom Tromey
2016-10-18 17:38 ` Pedro Alves
2016-10-19 22:29 ` Tom Tromey
2016-10-20 21:48 ` Tom Tromey
2016-10-20 21:56 ` Pedro Alves
2016-10-28 13:36 ` Pedro Alves [this message]
2016-10-31 2:48 ` Tom Tromey
2016-11-01 22:07 ` Tom Tromey
2016-11-02 16:12 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 14/17] Initial conversion of dwarf_expr_ctx Tom Tromey
2016-10-13 22:54 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 06/17] Record minimal symbols directly in reader Tom Tromey
2016-10-13 22:34 ` Pedro Alves
[not found] ` <87vawulj6w.fsf@tromey.com>
2016-10-20 21:47 ` Tom Tromey
2016-10-20 22:13 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 03/17] Use scoped_restore for current_ui Tom Tromey
2016-10-13 22:16 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 08/17] Remove some cleanups in MI Tom Tromey
2016-10-13 22:38 ` Pedro Alves
2016-10-13 21:11 ` [RFA v2 01/17] Use RAII to save and restore scalars Tom Tromey
2016-10-13 22:03 ` Pedro Alves
2016-10-13 21:13 ` [RFA v2 13/17] Some cleanup removal in dwarf2loc.c Tom Tromey
2016-10-13 22:52 ` Pedro Alves
2016-10-13 21:14 ` [RFA v2 09/17] Change command stats reporting to use class Tom Tromey
2016-10-13 22:43 ` Pedro Alves
2016-10-13 21:18 ` [RFA v2 17/17] Remove last cleanup from captured_main_1 Tom Tromey
2016-10-13 23:13 ` Pedro Alves
2016-10-13 21:39 ` [RFA v2 00/17] more C++ Pedro Alves
2016-10-14 16:26 ` Pedro Alves
2016-10-20 21:49 ` Tom Tromey
2016-10-20 22:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0005a6d-4f0f-ca54-e0c1-18cad7fc7656@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox