From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10754 invoked by alias); 4 Jan 2003 16:21:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10746 invoked from network); 4 Jan 2003 16:21:52 -0000 Received: from unknown (HELO main.gmane.org) (80.91.224.249) by 209.249.29.67 with SMTP; 4 Jan 2003 16:21:52 -0000 Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18Ur2P-0004HT-00 for ; Sat, 04 Jan 2003 17:20:41 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gdb-patches@sources.redhat.com Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18Ur2P-0004HK-00 for ; Sat, 04 Jan 2003 17:20:41 +0100 Path: not-for-mail From: "Raoul Gough" Subject: Re: coffread.c extension for DLLs without debugging symbols Date: Sat, 04 Jan 2003 16:21:00 -0000 Message-ID: References: <2110-Sat04Jan2003130101+0200-eliz@is.elta.co.il> X-Complaints-To: usenet@main.gmane.org X-Newsreader: Microsoft Outlook Express 6.00.2600.0000 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 X-SW-Source: 2003-01/txt/msg00147.txt.bz2 "Eli Zaretskii" wrote in message news:2110-Sat04Jan2003130101+0200-eliz@is.elta.co.il... > > From: "Raoul Gough" > > Date: Fri, 3 Jan 2003 19:39:31 -0000 > > > > This is my *first* gdb patch submission, > > so someone with more experience should probably take a good look at > > (e.g. is coffread.c the right place for this kind of code?). > > Lesson number 1: post the diffs as plain text, not uuencoded or > otherwise encoded. Some people, such as myself, don't have time to > open binary attachments, but do have time to read a patch that's in > plain text. OK, point taken. I was assuming that it was better to reduce some bandwidth, given the size of the patch (circa 10kB). OK, you can all laugh at me now for being so bandwidth-challenged that I still think about that stuff :-) > > Also, please include "[RFA]" in the subject, so that we know you are > seeking an approval for your patch. What does RFA stand for? Seemed to me like it was used by people who were actually capable of updating the CVS themselves and just wanted confirmation. > > > Proposed ChangeLog entry, assuming the code is accepted: > > > > 2003-01-03 Raoul Gough > > > > * coffread.c: Support non-debug export symbols for win32 DLLs > > This should mention every function where changes are made, preferably > with a description of a change in each one of them. Done! See my reply to Christopher Faylor on the patches mailing list. > > And thanks for working on this. No problem - hope it's useful to some people. Regards, Raoul Gough.