Re: [PATCH, gdb/exp] Handle DW_OP_GNU_variable_value refs to abstract dies

Tom de Vries
2018-09-06T06:40:35Z

On 09/06/2018 05:45 AM, Tom Tromey wrote:
>>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
>
> Kevin> Is there a good reason to use VEC instead of std::vector? I know that
> Kevin> there have been a number of patches which have been replacing VEC
> Kevin> with std:vector. So, unless there's a compelling reason to use VEC,
> Kevin> we might as well use std:vector here and save someone else the effort
> Kevin> of changing this use of VEC later on.
>
> Thanks for this note. One of my gdb c++-ification/cleanup goals is to
> get rid of VEC.

It would be nice if the sources reflected that fact.

F.i., we could move the contents from vec.{c,h} to vec-deprecated.{c.h}
and include the new files in vec.{c,h}, and add a note there why they're
deprecated.

I can prepare a patch implementing this or another approach, if there
are better suggestions.

Thanks,
- Tom