Re: [binutils-gdb] Style the gdb welcome message

Andrew Burgess
2019-10-15T08:32:40Z

* Tom Tromey <tom@tromey.com> [2019-10-14 16:45:54 -0600]:

> Maciej> I missed that in the various distractions that kept me from using an
> Maciej> up-to-date version of GDB, but now that I came across it the hard way the
> Maciej> bright pink version line hurts my eyes and disturbs me. Setting:
> Maciej> set style enabled off
> Maciej> in ~/.gdbinit does not make any change to it, so I find it a functional
> Maciej> regression. I'm sure there were important reasons to make this change,
> Maciej> but can we please get it under user control somehow?
>
> I added this to make it clear to users that gdb is style-enabled now.
> I guess I don't care much about this particular instance though. Maybe
> removing it is the answer.
>
> I'm curious to hear what others think. In the absence of comments I'll
> remove it sometime before 9.1, I think. Or I'll approve a patch to
> do so.

FWIW I hadn't even noticed the use of colour there, so it certainly
doesn't bother me. On my machine with both a light background and a
dark background I don't see a bright pink, but a darker pink.

I guess there's no simple way that we could postpone printing the
welcome message until some later point, say, just before GDB tries to
print anything else?

What this might mean is that if ~/.gdbinit contains only (or starts
with) commands that produce no output, for example 'set style enabled
off' then these would be processed before GDB printed the welcome
message.

I've not looked at the code at all, so have no idea how hard this
would be to actually do...

Thanks,
Andrew