Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Doug Evans <dje@google.com>
Cc: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
	       gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [BUILDROBOT] error: redefinition of typedef ‘record_line_ftype’ (was: [PATCH 3/6] DWARF Two Level Line Tables: check_line_address)
Date: Thu, 28 May 2015 17:27:00 -0000	[thread overview]
Message-ID: <alpine.LFD.2.11.1505281819240.21603@eddie.linux-mips.org> (raw)
In-Reply-To: <CADPb22SMqtn86MxgQP4E=f_EgcqA8n=8qpdEHyTheB5hqZAYZw@mail.gmail.com>

On Thu, 28 May 2015, Doug Evans wrote:

> >  The typedef in buildsym.h has to stay, it's already used elsewhere.
> > It's the newly-added one in dwarf2read.c that has to go.  Both are
> > identical anyway.
> 
> Fixed.

 Thanks!

> The build didn't fail for me so I didn't see this.
> I then tried several pure gcc versions (can't trust distro gcc defaults).
> I got a failure with 4.3.3 but not with 4.[6-9].x.

 The version I've been using is 6.0 head, so I guess in the quest for 
perfection GCC has become strictier since 4.9 here as well.  It might be 
worth trying 5.0, being a proper release rather than WIP.

 Offhand I can't tell if the complaint was legitimate or not.  I suspect 
it was, even though the redefinition merely repeated the original, but in 
any case the extra typedef was redundant.

  Maciej


      reply	other threads:[~2015-05-28 17:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 20:03 [PATCH 3/6] DWARF Two Level Line Tables: check_line_address Doug Evans
2015-05-27 20:28 ` Doug Evans
2015-05-28  9:27   ` [BUILDROBOT] error: redefinition of typedef ‘record_line_ftype’ (was: [PATCH 3/6] DWARF Two Level Line Tables: check_line_address) Jan-Benedict Glaw
2015-05-28 13:58     ` Maciej W. Rozycki
2015-05-28 16:52       ` Doug Evans
2015-05-28 17:27         ` Maciej W. Rozycki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.11.1505281819240.21603@eddie.linux-mips.org \
    --to=macro@linux-mips.org \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jbglaw@lug-owl.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox