From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98334 invoked by alias); 28 May 2015 13:58:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98320 invoked by uid 89); 28 May 2015 13:58:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-HELO: cvs.linux-mips.org Received: from eddie.linux-mips.org (HELO cvs.linux-mips.org) (148.251.95.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 May 2015 13:58:55 +0000 Received: (from localhost user: 'macro', uid#1010) by eddie.linux-mips.org with ESMTP id S27007437AbbE1N6ue4y0X (ORCPT ); Thu, 28 May 2015 15:58:50 +0200 Date: Thu, 28 May 2015 13:58:00 -0000 From: "Maciej W. Rozycki" To: Jan-Benedict Glaw cc: Doug Evans , gdb-patches Subject: =?ISO-8859-7?Q?Re=3A_=5BBUILDROBOT=5D_error=3A_redefinition_of_typedef_=A1record=5Fline=5Fftype=A2_=28was=3A_=5BPATCH_3=2F6=5D_DWARF_Two_Level_Line_Tables=3A_check=5Fline=5Faddress=29?= In-Reply-To: <20150528092738.GY7864@lug-owl.de> Message-ID: References: <20150528092738.GY7864@lug-owl.de> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-7 Content-Transfer-Encoding: 8BIT X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00680.txt.bz2 On Thu, 28 May 2015, Jan-Benedict Glaw wrote: > > > This patch just factors out the checking of a line address > > > to improve the S/N ratio of the calling function. > > > > > > 2015-03-12 Doug Evans > > > > > > * dwarf2read.c (record_line_ftype): New typedef. > > > (check_line_address): New function. > > > (dwarf_decode_lines_1): Call it. > > > > Committed. > > Seems it's breaking, see eg. this xtensa-linux build > (http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=442962), > or hppa-linux > (http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=443000): > > [...] > gcc -g -O2 -I. -I/home/jbglaw/repos/binutils_gdb/gdb -I/home/jbglaw/repos/binutils_gdb/gdb/common -I/home/jbglaw/repos/binutils_gdb/gdb/config -DLOCALEDIR="\"/home/jbglaw/build/hppa-linux/_install_/share/locale\"" -DHAVE_CONFIG_H -I/home/jbglaw/repos/binutils_gdb/gdb/../include/opcode -I/home/jbglaw/repos/binutils_gdb/gdb/../opcodes/.. -I/home/jbglaw/repos/binutils_gdb/gdb/../readline/.. -I/home/jbglaw/repos/binutils_gdb/gdb/../zlib -I../bfd -I/home/jbglaw/repos/binutils_gdb/gdb/../bfd -I/home/jbglaw/repos/binutils_gdb/gdb/../include -I../libdecnumber -I/home/jbglaw/repos/binutils_gdb/gdb/../libdecnumber -I/home/jbglaw/repos/binutils_gdb/gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.6 -I/usr/include/python2.6 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wpointer-sign -Wmissing-prototypes -Wdeclaration-after-statement -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o dwarf2read.o -MT dwarf2read.o -MMD -MP -MF .deps/dwarf2read.Tpo /home/jbglaw/repos/binutils_gdb/gdb/dwarf2read.c > /home/jbglaw/repos/binutils_gdb/gdb/dwarf2read.c:17480: error: redefinition of typedef ¡record_line_ftype¢ > /home/jbglaw/repos/binutils_gdb/gdb/buildsym.h:177: note: previous declaration of ¡record_line_ftype¢ was here > make[1]: *** [dwarf2read.o] Error 1 > make[1]: Leaving directory `/home/jbglaw/build/hppa-linux/build-gdb/gdb' > make: *** [all-gdb] Error 2 > > Probably just missed a small part of the patch which removed the > second definition? Also mips-linux; any build probably. The typedef in buildsym.h has to stay, it's already used elsewhere. It's the newly-added one in dwarf2read.c that has to go. Both are identical anyway. Maciej