From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mS3rMCJjYmrXVSoAWB0awg (envelope-from ) for ; Thu, 23 Jul 2026 14:53:22 -0400 Received: by simark.ca (Postfix, from userid 112) id C18D11E09E; Thu, 23 Jul 2026 14:53:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2BF7D1E033 for ; Thu, 23 Jul 2026 14:53:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FABE4BA23E5 for ; Thu, 23 Jul 2026 18:53:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FABE4BA23E5 Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by sourceware.org (Postfix) with ESMTP id D64834BA23D9 for ; Thu, 23 Jul 2026 18:52:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D64834BA23D9 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D64834BA23D9 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:4190:8020::34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784832772; cv=none; b=fjSySQMZWf4emZQdBluOO2HE/hj/v7PcOlIykqC9x6UliZ+iqb/MDnpJEzkU37+51EC/bfD/ByI++ENpow/UshqThxhP+hA8/dlrQ+tKqa8RsPenchxQr5tvAkZfN1vc/2nGXOah8YHDEpesX1Anr0y7lX+WgysPpL9FUK/6edc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784832772; c=relaxed/simple; bh=xcqF509HBvO5G0IuMknEUSKEt2uD579Y7ygl/hZvrOs=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=joZgiJU5sQ6N/+MhRJCKT6NNQPZgPR8J55fgRLG+GiNP50EdH1jPQptqtJakWt8fPswsHCreGF7vHCqL4VHGjDxuC6ad9fvf16HhbgBEr5nNIIToDJx5OvrYWXixkCsmEm+qUe2TudvN851ySkl8KEETjtZffTM4/JWDvf4bgqw= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D64834BA23D9 Received: by angie.orcam.me.uk (Postfix, from userid 500) id 5EEDE92009C; Thu, 23 Jul 2026 20:52:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 5861A92009B; Thu, 23 Jul 2026 19:52:51 +0100 (BST) Date: Thu, 23 Jul 2026 19:52:51 +0100 (BST) From: "Maciej W. Rozycki" To: gdb-patches@sourceware.org cc: Jovan Dmitrovic , Djordje Todorovic , Milica Matic , "Maciej W. Rozycki" Subject: [PATCH 2/7] PowerPC/testsuite: Reduce feature tests in terms of `allow_target_tests' In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Maciej W. Rozycki" Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Maciej W. Rozycki Reimplement `allow_altivec_tests', `allow_power_isa_3_1_tests', and `allow_vsx_tests' in terms of `allow_target_tests', removing duplicate code. No functional change. Eventually it may make sense to migrate the resulting wrappers to testsuite/gdb.arch/ so as to declutter generic test framework from target-specific stuff. --- gdb/testsuite/lib/gdb.exp | 163 +++++++++------------------------------------- 1 file changed, 35 insertions(+), 128 deletions(-) gdb-powerpc-test-target-allow.diff Index: binutils-gdb/gdb/testsuite/lib/gdb.exp =================================================================== --- binutils-gdb.orig/gdb/testsuite/lib/gdb.exp +++ binutils-gdb/gdb/testsuite/lib/gdb.exp @@ -4333,8 +4333,6 @@ proc allow_target_tests { me feature mes # 0 if it does not. Based on 'check_vmx_hw_available' from the GCC testsuite. gdb_caching_proc allow_altivec_tests {} { - global srcdir subdir gdb_prompt inferior_exited_re - set me "allow_altivec_tests" # Some simulators are known to not support VMX instructions. @@ -4350,110 +4348,47 @@ gdb_caching_proc allow_altivec_tests {} # Make sure we have a compiler that understands altivec. if {[test_compiler_info gcc*]} { - set compile_flags "additional_flags=-maltivec" + set flags "-maltivec" } elseif {[test_compiler_info xlc*]} { - set compile_flags "additional_flags=-qaltivec" + set flags "-qaltivec" } else { verbose "Could not compile with altivec support, returning 0" 2 return 0 } # Compile a test program containing VMX instructions. - set src { - int main() { - #ifdef __MACH__ - asm volatile ("vor v0,v0,v0"); - #else - asm volatile ("vor 0,0,0"); - #endif - return 0; - } - } - if {![gdb_simple_compile $me $src executable $compile_flags]} { - return 0 - } - - # Compilation succeeded so now run it via gdb. - - gdb_exit - gdb_start - gdb_reinitialize_dir $srcdir/$subdir - gdb_load "$obj" - gdb_run_cmd - gdb_expect { - -re ".*Illegal instruction.*${gdb_prompt} $" { - verbose -log "\n$me altivec hardware not detected" - set allow_vmx_tests 0 - } - -re ".*$inferior_exited_re normally.*${gdb_prompt} $" { - verbose -log "\n$me: altivec hardware detected" - set allow_vmx_tests 1 - } - default { - warning "\n$me: default case taken" - set allow_vmx_tests 0 - } - } - gdb_exit - remote_file build delete $obj - - verbose "$me: returning $allow_vmx_tests" 2 - return $allow_vmx_tests + return [allow_target_tests $me "altivec hardware" "Illegal instruction" \ + { + int main() { + #ifdef __MACH__ + asm volatile ("vor v0,v0,v0"); + #else + asm volatile ("vor 0,0,0"); + #endif + return 0; + } + } \ + $flags] } # Run a test on the power target to see if it supports ISA 3.1 instructions gdb_caching_proc allow_power_isa_3_1_tests {} { - global srcdir subdir gdb_prompt inferior_exited_re - - set me "allow_power_isa_3_1_tests" - # Compile a test program containing ISA 3.1 instructions. - set src { - int main() { - asm volatile ("pnop"); // marker + return [allow_target_tests "allow_power_isa_3_1_tests" \ + "Power ISA 3.1 hardware" "Illegal instruction" \ + { + int main() { + asm volatile ("pnop"); // marker asm volatile ("nop"); return 0; } - } - - if {![gdb_simple_compile $me $src executable ]} { - return 0 - } - - # No error message, compilation succeeded so now run it via gdb. - - gdb_exit - gdb_start - gdb_reinitialize_dir $srcdir/$subdir - gdb_load "$obj" - gdb_run_cmd - gdb_expect { - -re ".*Illegal instruction.*${gdb_prompt} $" { - verbose -log "\n$me Power ISA 3.1 hardware not detected" - set allow_power_isa_3_1_tests 0 - } - -re ".*$inferior_exited_re normally.*${gdb_prompt} $" { - verbose -log "\n$me: Power ISA 3.1 hardware detected" - set allow_power_isa_3_1_tests 1 - } - default { - warning "\n$me: default case taken" - set allow_power_isa_3_1_tests 0 - } - } - gdb_exit - remote_file build delete $obj - - verbose "$me: returning $allow_power_isa_3_1_tests" 2 - return $allow_power_isa_3_1_tests + }] } # Run a test on the target to see if it supports vmx hardware. Return 1 if so, # 0 if it does not. Based on 'check_vmx_hw_available' from the GCC testsuite. gdb_caching_proc allow_vsx_tests {} { - global srcdir subdir gdb_prompt inferior_exited_re - set me "allow_vsx_tests" # Some simulators are known to not support Altivec instructions, so @@ -4465,56 +4400,28 @@ gdb_caching_proc allow_vsx_tests {} { # Make sure we have a compiler that understands altivec. if {[test_compiler_info gcc*]} { - set compile_flags "additional_flags=-mvsx" + set flags "-mvsx" } elseif {[test_compiler_info xlc*]} { - set compile_flags "additional_flags=-qasm=gcc" + set flags "-qasm=gcc" } else { verbose "Could not compile with vsx support, returning 0" 2 return 0 } # Compile a test program containing VSX instructions. - set src { - int main() { - double a[2] = { 1.0, 2.0 }; - #ifdef __MACH__ - asm volatile ("lxvd2x v0,v0,%[addr]" : : [addr] "r" (a)); - #else - asm volatile ("lxvd2x 0,0,%[addr]" : : [addr] "r" (a)); - #endif - return 0; - } - } - if {![gdb_simple_compile $me $src executable $compile_flags]} { - return 0 - } - - # No error message, compilation succeeded so now run it via gdb. - - gdb_exit - gdb_start - gdb_reinitialize_dir $srcdir/$subdir - gdb_load "$obj" - gdb_run_cmd - gdb_expect { - -re ".*Illegal instruction.*${gdb_prompt} $" { - verbose -log "\n$me VSX hardware not detected" - set allow_vsx_tests 0 - } - -re ".*$inferior_exited_re normally.*${gdb_prompt} $" { - verbose -log "\n$me: VSX hardware detected" - set allow_vsx_tests 1 - } - default { - warning "\n$me: default case taken" - set allow_vsx_tests 0 - } - } - gdb_exit - remote_file build delete $obj - - verbose "$me: returning $allow_vsx_tests" 2 - return $allow_vsx_tests + return [allow_target_tests $me "VSX hardware" "Illegal instruction" \ + { + int main() { + double a[2] = { 1.0, 2.0 }; + #ifdef __MACH__ + asm volatile ("lxvd2x v0,v0,%[addr]" : : [addr] "r" (a)); + #else + asm volatile ("lxvd2x 0,0,%[addr]" : : [addr] "r" (a)); + #endif + return 0; + } + } \ + $flags] } # Run a test on the target to see if it supports TSX hardware. Return 1 if so,