[PING][PATCH] binutils-gdb/git: Handle *.ac and *.m4 files in .gitattributes

Tom de Vries
2025-12-17T21:26:16Z

On 12/3/25 9:51 AM, Tom de Vries wrote:
> Since commit 52ca3d3fe61 ("toplevel: unify the GCC and GDB/binutils .editorconfig
> files"), .editorconfig has settings for .ac and .m4 files:
> ...
> [*.{ac,m4}]
> indent_style = tab
> indent_size = 2
> trim_trailing_whitespace = true
> ...
>
> There are no setting for those files in .gitattributes, so the whitespace
> attribute defaults to trailing-space (shorthand for blank-at-eol,
> blank-at-eof) and space-before-tab.
>
> Since according to .editorconfig the indentation style is tab, add
> indent-with-non-tab as well.
>
> Since aclocal.m4 is generated, unset the whitespace attribute. Likewise for
> configure.

Ping.

Thanks,
- Tom

> ---
> .gitattributes | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/.gitattributes b/.gitattributes
> index 6f7c6d8ba52..3639ebcfe55 100644
> --- a/.gitattributes
> +++ b/.gitattributes
> @@ -33,3 +33,13 @@ ChangeLog merge=merge-changelog
> *.[cChH] whitespace=space-before-tab,indent-with-non-tab,trailing-space
> *.exp whitespace=space-before-tab,indent-with-non-tab,trailing-space
> *.tcl whitespace=space-before-tab,indent-with-non-tab,trailing-space
> +
> +# Autoconf.
> +
> +*.ac whitespace=space-before-tab,indent-with-non-tab,trailing-space
> +*.m4 whitespace=space-before-tab,indent-with-non-tab,trailing-space
> +
> +# Generated files.
> +
> +configure -whitespace
> +aclocal.m4 -whitespace
>
> base-commit: d03293898d81e4273ac7f9163a8186dba46db0e5