Re: [PATCH] binutils-gdb/git: Handle *.ac and *.m4 files in .gitattributes

Tom Tromey
2025-12-04T16:33:24Z

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Since commit 52ca3d3fe61 ("toplevel: unify the GCC and GDB/binutils .editorconfig
Tom> files"), .editorconfig has settings for .ac and .m4 files:
Tom> ...
Tom> [*.{ac,m4}]
Tom> indent_style = tab
Tom> indent_size = 2
Tom> trim_trailing_whitespace = true
Tom> ...

Tom> There are no setting for those files in .gitattributes, so the whitespace
Tom> attribute defaults to trailing-space (shorthand for blank-at-eol,
Tom> blank-at-eof) and space-before-tab.

Tom> Since according to .editorconfig the indentation style is tab, add
Tom> indent-with-non-tab as well.

Tom> Since aclocal.m4 is generated, unset the whitespace attribute. Likewise for
Tom> configure.

FWIW this seems fine to me.

Tom