From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qOXEORt/ZWixPikAWB0awg (envelope-from ) for ; Wed, 02 Jul 2025 14:48:59 -0400 Received: by simark.ca (Postfix, from userid 112) id DCCB21E11E; Wed, 2 Jul 2025 14:48:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D61161E0C2 for ; Wed, 2 Jul 2025 14:48:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6DC013852FDB for ; Wed, 2 Jul 2025 18:48:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6DC013852FDB Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by sourceware.org (Postfix) with ESMTP id 7447B385782C for ; Wed, 2 Jul 2025 18:48:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7447B385782C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7447B385782C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4190:8020::34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751482111; cv=none; b=xJ36Wsm9i6sTbqDkAn4Hv1llHEejnLJa/U+GLHK1I6ulOHVYh8rXLumGwc2e4ZUtVT2e71+mtv0pjgoL1/gNYzI8+EnCvJrc1fIOInagtdZCrvFdHFjO3wYuBTX6Dhm+ZoNPIjKOwAiYWg4PM+EV0je36F+/MSrQ7iTRRJMsSIg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751482111; c=relaxed/simple; bh=7KoZkxObujaYemjs3snx3Qqj84ZWTRgYpWCASHB/D68=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=m1O9nBMNOkaMw8j5lCQf8uXHNvl8uXmHS2/xq/a4x/dxXDuSl2g8vbcXWBD2jZzNbK2nFVE65MGX3a8L5UmIK9ggafMY9BOSexgHPZJZHq5/gzkaF/hNq5C6VBHWxC1mF1rUqAHk+KOpZClmlHu8aA7+QvL4EBSNu54A642ImpY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7447B385782C Received: by angie.orcam.me.uk (Postfix, from userid 500) id 9303792009C; Wed, 2 Jul 2025 20:48:30 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 8EC3A92009B; Wed, 2 Jul 2025 19:48:30 +0100 (BST) Date: Wed, 2 Jul 2025 19:48:30 +0100 (BST) From: "Maciej W. Rozycki" To: Yodel Eldar cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb/alpha: Add target description support In-Reply-To: <20250526151219.399450-2-yodel.eldar@gmail.com> Message-ID: References: <20250526151219.399450-1-yodel.eldar@gmail.com> <20250526151219.399450-2-yodel.eldar@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, 26 May 2025, Yodel Eldar wrote: > diff --git a/gdb/alpha-tdep.c b/gdb/alpha-tdep.c > index f0272b0e49d..60888a6f475 100644 > --- a/gdb/alpha-tdep.c > +++ b/gdb/alpha-tdep.c > @@ -1822,6 +1830,7 @@ _initialize_alpha_tdep () > > gdbarch_register (bfd_arch_alpha, alpha_gdbarch_init, NULL); > > + initialize_tdesc_alpha (); > /* Let the user set the fence post for heuristic_proc_start. */ > > /* We really would like to have both "0" and "unlimited" work, but I think there should be a new line between the new addition and the comment below. This is the only minor nit I have about this change. Maciej