Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Milica Matic <milica.matic@htecgroup.com>
Cc: Djordje Todorovic <Djordje.Todorovic@htecgroup.com>,
	 Milos Kalicanin <milos.kalicanin@htecgroup.com>,
	 Simon Marchi <simark@simark.ca>, Chao-ying Fu <cfu@wavecomp.com>,
	 Andrew Burgess <aburgess@redhat.com>,
	Kevin Buettner <kevinb@redhat.com>,
	 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	 gdb-patches@sourceware.org
Subject: Re: [PATCH v12 2/2] gdb: mips: Add MIPSR6 support
Date: Fri, 28 Mar 2025 17:09:59 +0000 (GMT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2503281538120.47733@angie.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.2.21.2503012336080.12637@angie.orcam.me.uk>

On Sun, 2 Mar 2025, Maciej W. Rozycki wrote:

>  This all also means I can use the R3400 system to reliably verify GDB 
> changes and will proceed with your submission once I'm back from my 
> holiday in a fortnight's time.  Meanwhile I do hope this analysis helps.

 I have regression-tested your change now and while the problem previously 
noted persists with `call-ar-st' and `varargs' tests, leaving them stuck 
forever in a weird state:

macro     1299  0.0  0.0     0    0 ?        XW   Mar24   0:03 [call-ar-st]
macro     4501  0.0  0.0     0    0 ?        XW   Mar24   0:05 [varargs]

results are looking good otherwise, except for the newly-added R6 case:

Running .../gdb/testsuite/gdb.arch/mips-64-r6.exp ...
gdb compile failed, Assembler messages:
Fatal error: can't create .../gdb/testsuite/gdb.arch/mips-64-r60.o: No such file or directory
DUPLICATE: gdb.arch/mips-64-r6.exp: failed to prepare

This is because there's no output directory present for the object file 
requested: there's no gdb.arch/ under .../gdb/testsuite/.  I reckon it's 
been many years already since our directory arrangement here was changed.  
Have you run your verification with the upstream trunk version of GDB?

 Also the duplicate failure message needs to be corrected as test messages 
are expected to be uniquely identifiable.

 Please update your patch accordingly and resubmit; meanwhile I'll have a 
detailed look at the backend updates.

  Maciej

      reply	other threads:[~2025-03-28 17:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19 13:01 [PATCH 0/2] " Milica Matic
2025-02-19 13:01 ` [PATCH v12 " Milica Matic
2025-02-19 13:01 ` [PATCH v12 1/2] Apply coding guidelines Milica Matic
2025-02-19 23:21   ` Kevin Buettner
2025-02-23 16:40     ` Maciej W. Rozycki
2025-02-19 13:01 ` [PATCH v12 2/2] gdb: mips: Add MIPSR6 support Milica Matic
2025-02-25 22:35   ` Maciej W. Rozycki
2025-03-02  0:17     ` Maciej W. Rozycki
2025-03-28 17:09       ` Maciej W. Rozycki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2503281538120.47733@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=Djordje.Todorovic@htecgroup.com \
    --cc=aburgess@redhat.com \
    --cc=cfu@wavecomp.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=milica.matic@htecgroup.com \
    --cc=milos.kalicanin@htecgroup.com \
    --cc=simark@simark.ca \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox