From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qCH2OgG3q2d5gysAWB0awg (envelope-from ) for ; Tue, 11 Feb 2025 15:45:53 -0500 Received: by simark.ca (Postfix, from userid 112) id EF6531E105; Tue, 11 Feb 2025 15:45:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7DF3F1E08E for ; Tue, 11 Feb 2025 15:45:53 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1E1933858C39 for ; Tue, 11 Feb 2025 20:45:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1E1933858C39 Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by sourceware.org (Postfix) with ESMTP id C8A5B3858D34 for ; Tue, 11 Feb 2025 20:45:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C8A5B3858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C8A5B3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=78.133.224.34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739306724; cv=none; b=L4Lba4U9MAiJ7YmVmlDR19YE/xxjBf7FflYh44tSzO3WtOOJUGdfdsfQhs4hG0o1iQl/bDNUo9+451IMuvnLVPtAkz0tVJES0HJUX6QNYHsmMHscIOUB+KV4Z9Z7yZMSNsx0DtB2Dg0ucWheQKnxxZo88GbZZH33qV0ODuAxZGQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739306724; c=relaxed/simple; bh=nboJByhWoDl1GWrU7WKTvax2nROo3Wlzrxrv+WMIpIA=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=GK+lRNCgJXiwIrsBP3HNDgunUF3sU6NpaJAfUDqGUCmO+hWIhyDrz2spl4vRPKOphbMwVIPxtbU4jGlKOY1GbrmXn+SGqsQEUa89KaplIby0sbf5D8CokffiFW1Yo/Y30X1Wz5FhKI/dzMi28Zj8fcvW5ujPr087CtAxqiYOwQI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C8A5B3858D34 Received: by angie.orcam.me.uk (Postfix, from userid 500) id 952CF92009C; Tue, 11 Feb 2025 21:45:23 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 8F1E292009B; Tue, 11 Feb 2025 20:45:23 +0000 (GMT) Date: Tue, 11 Feb 2025 20:45:23 +0000 (GMT) From: "Maciej W. Rozycki" To: Kevin Buettner , Milica Matic cc: gdb-patches@sourceware.org, Djordje Todorovic , Milos Kalicanin , "simark@simark.ca" , "cfu@wavecomp.com" , "aburgess@redhat.com" Subject: Re: [PATCH^11] gdb: mips: Add MIPSR6 support In-Reply-To: <20250211131058.4962d6f6@f41-zbm-amd> Message-ID: References: <20250210172801.43302-1-milica.matic@htecgroup.com> <20250211131058.4962d6f6@f41-zbm-amd> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 11 Feb 2025, Kevin Buettner wrote: > > Changes from v10: Apply suggestions provided by Kevin Buettner. > > Additionaly, format mips-tdep.c code as described on links: > > https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards > > https://www.gnu.org/prep/standards/standards.html#Comments > > > > [1] "MIPS64 Architecture for Programmers Volume II-A: The MIPS64 > > Instruction Set Reference Manual", Document Number: MD00087, > > Revision 6.06, December 15, 2016, Section 3 "The MIPS64 > > Instruction Set", pp. 42-530 > > https://s3-eu-west-1.amazonaws.com/downloads-mips/documents/MD00087-2B-MIPS64BIS-AFP-6.06.pdf > > 2025-02-10 > > Andrew Bennett > > Matthew Fortune > > Faraz Shahbazker > > The code formatting looks good to me now. I have a concern about formatting changes to lines otherwise not affected by MIPSr6 additions, as they obfuscate the actual code change and would do so forever if pushed even if you verified that they are legitimate. Milica, can you therefore please filter them out (`diff -w' should help; there shouldn't be much if anything to fix up afterwards) and submit as a separate patch, perhaps a preparatory one? I know this is boring stuff, but we need to care about our sanity while handling this stuff long-term. > Additionally, I don't see anything obviously wrong with the MIPSR6 > support that's been added. That said, I'm not especially > knowledgeable about MIPS these days, so I ask that you wait a few days > for other maintainers to weigh in before pushing this patch. I'd like to have a look yet at the refreshed change as I've spotted some suspicious stuff I need to feel comfortable about before moving forward. Hopefully with the formatting noise moved out of the way it should be more straightforward for me to verify things. Thank you, Kevin, for taking the lead here. Maciej