Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Ivan Kokshaysky <ink@unseen.parts>, Nick Clifton <nickc@redhat.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] alpha, ld: remove -taso option
Date: Mon, 20 Jan 2025 17:50:32 +0000 (GMT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2501190626000.27432@angie.orcam.me.uk> (raw)
In-Reply-To: <Z4t_yqXpYf2J7b1Z@minute>

On Sat, 18 Jan 2025, Ivan Kokshaysky wrote:

> The -taso switch was quite useful 25 years ago for porting 32-bit
> code with broken integer-pointer casting. Not anymore. The EF_ALPHA_32BIT
> Linux support is going to be dropped in kernel v6.14 [1], NetBSD and OpenBSD
> never had it, so there is no point in keeping the -taso option around.
> 
> Also remove alpha special case that uses -taso from gdb.base/dump.exp
> in gdb testsuite.
> 
> [1] https://lore.kernel.org/all/87jzb2tdb7.fsf_-_@email.froward.int.ebiederm.org
> 
> Signed-off-by: Ivan Kokshaysky <ink@unseen.parts>
> ---
> Changes in v2, suggested by Maciej W. Rozycki:
>   - leave the translations alone;
>   - remove OPTION_TASO from ld/ldlex.h;
>   - add entries to ld/NEWS and binutils/NEWS.

 I forgot we have per-tool-directory NEWS, so thanks for updating ld/NEWS 
and I think we don't want a duplicate entry in binutils/NEWS, which is for 
the other tools.  No need to send v3 I suppose, this can be fixed up at 
patch installation time.

 Your change looks good to me and I've run it through binutils regression 
testing, so as long as Nick is fine with it and someone on the GDB side 
acks the GDB test update I can install it for you once binutils 2.44 have 
been released in ~fortnight time.

  Maciej

  reply	other threads:[~2025-01-20 17:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Z4pr4tVtVYToa5YU@minute>
2025-01-17 14:47 ` [PATCH] " Sam James
2025-01-17 15:00   ` Ivan Kokshaysky
2025-01-17 21:17     ` Sam James
2025-01-18  7:33 ` Maciej W. Rozycki
2025-01-18  7:37   ` Maciej W. Rozycki
2025-01-18  8:40     ` Ivan Kokshaysky
2025-01-18 10:17     ` [PATCH v2] " Ivan Kokshaysky
2025-01-20 17:50       ` Maciej W. Rozycki [this message]
     [not found]       ` <f203eaa7-41a5-4b87-80cc-ab0d0e2edd9c@redhat.com>
2025-02-11 17:02         ` Maciej W. Rozycki
2025-02-11 17:43       ` Andrew Burgess
2025-02-15  1:36         ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2501190626000.27432@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ink@unseen.parts \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox