From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qBeyFUmCd2d0hwEAWB0awg (envelope-from ) for ; Fri, 03 Jan 2025 01:23:05 -0500 Received: by simark.ca (Postfix, from userid 112) id 56D1D1E097; Fri, 3 Jan 2025 01:23:05 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 115ED1E091 for ; Fri, 3 Jan 2025 01:23:05 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BF53E3858CDA for ; Fri, 3 Jan 2025 06:23:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF53E3858CDA Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by sourceware.org (Postfix) with ESMTP id 5D0383858D1E; Fri, 3 Jan 2025 06:22:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5D0383858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5D0383858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=78.133.224.34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735885355; cv=none; b=vjlBXWp8f9mrNaQaEOZuOuRMuI86p+xHhAqnwGbQmGogNkQeFPr9ecRcNpwluk9rJIV7z58Qo0Bfs81VJq4SgCaJTuWEIFVBr2wB9CrdKnp469rf4rLXvSpMdzqND37TlqVdP90BAmuEE+7Dhb+4gIrLRR80C4Au6FYv4OpNVD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735885355; c=relaxed/simple; bh=muanGcqaV0RxZj5N5zERdUp45aA/BsP4YKu0829f4P8=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=s45CS0spGrfkMmetk4GllY/6oW40MbK6TG6EnVs7mfQWYqQRM/rbM89FGlb07CQLZvISiXj9Lv+0v2t196OlVQeUBtWKMkvLgxVirLJ9uH0ldauXjpxpm8VYHcqJ9iQtFrNyrjE0HZxu52mpICdSXTGvl9TbzmvBGoiQd1qI5sw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D0383858D1E Received: by angie.orcam.me.uk (Postfix, from userid 500) id C18C392009C; Fri, 3 Jan 2025 07:22:34 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id BBC0F92009B; Fri, 3 Jan 2025 06:22:34 +0000 (GMT) Date: Fri, 3 Jan 2025 06:22:34 +0000 (GMT) From: "Maciej W. Rozycki" To: Charlie Jenkins cc: Jan Beulich , Nelson Chu , jiawei , gdb-patches , Binutils , Andrew Burgess Subject: Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions In-Reply-To: Message-ID: References: <20241216-fix_objdump_partial_insn-v2-1-8de88a115dbc@rivosinc.com> <2b869ed1-5969-4ac8-890e-5c82f1877543@suse.com> <3bf293a6-63dd-4ee9-9b3c-368c48476513@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 2 Jan 2025, Charlie Jenkins wrote: > > That or "display" instead of "disassembly", if you ask me. > > Sounds good, thank you for letting me know. Is there anything beyond > this wording that is of concern in this patch? Unless there is anything > else that needs to be changed, I can send a new version with the same > diff (containing Nelson's comments) but change "disassembly" to > "display" in the title and message. I think relevant test cases need to be added to the testsuite, I guess under binutils/testsuite/binutils-all/riscv/ as this covers `objdump' rather than any of the other tools. This is to guarantee things won't regress again by accident. Maciej