From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-bounces+public-inbox=simark.ca@sourceware.org>
Received: from simark.ca
	by simark.ca with LMTP
	id cC68IukpeWKWRAUAWB0awg
	(envelope-from <gdb-patches-bounces+public-inbox=simark.ca@sourceware.org>)
	for <public-inbox@simark.ca>; Mon, 09 May 2022 10:49:13 -0400
Received: by simark.ca (Postfix, from userid 112)
	id 8B2201E21F; Mon,  9 May 2022 10:49:13 -0400 (EDT)
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI,
	RDNS_DYNAMIC autolearn=ham autolearn_force=no version=3.4.6
Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPS id E8CE51E00D
	for <public-inbox@simark.ca>; Mon,  9 May 2022 10:49:12 -0400 (EDT)
Received: from server2.sourceware.org (localhost [IPv6:::1])
	by sourceware.org (Postfix) with ESMTP id 760E5394D88B
	for <public-inbox@simark.ca>; Mon,  9 May 2022 14:49:12 +0000 (GMT)
Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34])
 by sourceware.org (Postfix) with ESMTP id F1D58394BE11
 for <gdb-patches@sourceware.org>; Mon,  9 May 2022 14:44:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F1D58394BE11
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
 id 7AE4E9200C4; Mon,  9 May 2022 16:44:15 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by angie.orcam.me.uk (Postfix) with ESMTP id 7408A9200C1;
 Mon,  9 May 2022 15:44:15 +0100 (BST)
Date: Mon, 9 May 2022 15:44:15 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] gdbserver: Remove srv_linux_usrregs setting in RISCV
In-Reply-To: <87tu9yiydt.fsf@tromey.com>
Message-ID: <alpine.DEB.2.21.2205091542560.52331@angie.orcam.me.uk>
References: <20220509123957.11327-1-tangyouling@loongson.cn>
 <87tu9yiydt.fsf@tromey.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
Cc: Youling Tang <tangyouling@loongson.cn>, gdb-patches@sourceware.org
Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org
Sender: "Gdb-patches"
 <gdb-patches-bounces+public-inbox=simark.ca@sourceware.org>

On Mon, 9 May 2022, Tom Tromey wrote:

> > In the linux kernel code of RISCV, ptrace does not have the implementation
> > of PTRACE_POKEUSR/PTRACE_PEEKUSR in the arch_ptrace function (like aarch64),
> > If srv_linux_usrregs is set to yes, HAVE_LINUX_USRREGS will be defined, so
> > remove the srv_linux_usrregs setting.
> 
> Looks reasonable to me.

 Yeah, it must have been an oversight.  Thanks for the fix!

  Maciej