Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: "Wiederhake, Tim" <tim.wiederhake@intel.com>,
	Sergio Durigan Junior	<sergiodj@redhat.com>,
	"gdb-patches@sourceware.org"	<gdb-patches@sourceware.org>
Subject: Re: Breakage on builder Fedora-x86_64-w64-mingw32, revision 49b000dc5686e016f05b717f18d2c8f865eb3617 [gdb-8.12-branch]
Date: Fri, 20 Jul 2018 20:40:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.20.1807202037100.27257@digraph.polyomino.org.uk> (raw)
In-Reply-To: <c9892053-ba73-7173-c871-cd56db02b6f9@redhat.com>

On Fri, 13 Jul 2018, Pedro Alves wrote:

> > Yep, if I
> >  touch src/intl/plural.c
> > then
> >  rm -f build/intl/plural.* && make -C intl
> > build successfully.
> > 
> > I kind of have the feeling I've seen this discussed before.
> 
> Found <https://sourceware.org/ml/binutils/2014-12/msg00107.html>.
> 
> Looks like there's an intl fix, but nobody ever imported it into
> our copy (starting with updating gcc's copy).
> 
> Anyone want to take a stab at it?

Or you could follow what we did for glibc, and stop having plural.c being 
checked in to either the GCC or binutils-gdb repository, and arrange for 
it to be generated in the build directory.  (With due care to ensure it 
gets into release tarballs, which for GCC means ensuring 
--enable-generated-files-in-srcdir causes it to go in the source 
directory, and that if you build from a release tarball that does have it 
in the source directory, the source directory copy gets used when you 
don't have Bison installed.)

For binutils and GDB, Bison is already a build requirement when building 
from version control.  GCC doesn't currently have any Bison parsers, so 
this would be restoring an old build requirement there.

-- 
Joseph S. Myers
joseph@codesourcery.com


      reply	other threads:[~2018-07-20 20:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12  7:59 Oh dear. I regret to inform you that commit 49b000dc5686e016f05b717f18d2c8f865eb3617 might be unfortunate [gdb-8.12-branch] gdb-buildbot
2018-07-12  7:59 ` Breakage on builder Fedora-x86_64-w64-mingw32, revision 49b000dc5686e016f05b717f18d2c8f865eb3617 [gdb-8.12-branch] gdb-buildbot
2018-07-12 16:21   ` Pedro Alves
2018-07-12 16:53     ` Sergio Durigan Junior
2018-07-13 10:55       ` Wiederhake, Tim
2018-07-13 11:16         ` Pedro Alves
2018-07-13 11:21           ` Pedro Alves
2018-07-20 20:40             ` Joseph Myers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1807202037100.27257@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=sergiodj@redhat.com \
    --cc=tim.wiederhake@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox