From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54331 invoked by alias); 25 May 2018 11:54:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54279 invoked by uid 89); 25 May 2018 11:54:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: 9pmail.ess.barracuda.com Received: from 9pmail.ess.barracuda.com (HELO 9pmail.ess.barracuda.com) (64.235.150.225) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 May 2018 11:54:29 +0000 Received: from mipsdag02.mipstec.com (mail2.mips.com [12.201.5.32]) by mx1.ess.sfj.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=NO); Fri, 25 May 2018 11:53:36 +0000 Received: from [10.20.78.206] (10.20.78.206) by mipsdag02.mipstec.com (10.20.40.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Fri, 25 May 2018 04:53:38 -0700 Date: Fri, 25 May 2018 13:49:00 -0000 From: "Maciej W. Rozycki" To: Pedro Alves CC: , Djordje Todorovic Subject: Re: [PATCH] testsuite: Extend TLS core file testing with an OS-generated dump In-Reply-To: <8f45ebc8-8b8e-57b7-be5b-15e2f509d5f6@redhat.com> Message-ID: References: <5b76142d-479d-3c34-9294-9f4510d0fc04@redhat.com> <8f45ebc8-8b8e-57b7-be5b-15e2f509d5f6@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: mipsdag02.mipstec.com (10.20.40.47) To mipsdag02.mipstec.com (10.20.40.47) X-BESS-ID: 1527249216-298552-15051-45031-1 X-BESS-VER: 2018.6-r1805181819 X-BESS-Apparent-Source-IP: 12.201.5.32 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.193350 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status:1 X-SW-Source: 2018-05/txt/msg00662.txt.bz2 On Thu, 24 May 2018, Pedro Alves wrote: > > I'd keep that: > > > > rename tls_core_test "" > > > > command that I added at the end though, so as not to clutter the procedure > > space. Otherwise it'll stay there thoughout the rest of a test suite run > > (we have some leftover clutter in the testsuite already, which sometimes > > makes different .exp scripts interact with each other). > > Ah, forgot to comment that. I think that would be a losing battle. > We already have too many tests defining procedures and global variables > and we never took that care. And frankly, it looks a bit too onerous > to me. Particularly since to do it throughout would imply undefining > procedures at every early-bail-out return path too. > > I think a better approach is to isolate the testcases somehow. > > One way is to put each testcase in its own tcl namespace. It still > wouldn't isolate properly if you test with more than one board at the > same time, like "--target_board=foo,bar". Given your observations I've thought about namespaces too, especially as they can be deleted once they're done with. So why wouldn't they work with `--target_board=foo,bar', how is the test suite executed in such an arrangement? > Another way is to make sure that we run each testcase in its own > separate 'expect' process. We actually can already do the latter, > if you run the testsuite with "make check-parallel", like e.g.,: > > $ make check-parallel TESTS="gdb.*/tls-core.exp */break.exp" > > so we'd need to make "make check" do that by default. I think > this might be the most promising approach. Are globals available to those separate processes though? What if one is updated as a side-effect of a library procedure called from a test case, (like to achieve a caching effect)? > > WARNING: can't generate a core file - core tests suppressed - check ulimit -c > > UNSUPPORTED: gdb.threads/tls-core.exp: native: load core file > > UNSUPPORTED: gdb.threads/tls-core.exp: native: print thread-local storage variable > > > > here. Will you handle all this or shall I? > > I've handled this now, and pushed the patch, as below. Great, thanks! > > Many thanks for taking care of this. Your updated test script actually > > helped me greatly with a test case for the next change I am going to push > > (another MIPS/Linux core file mishandling -- we live in a reality separate > > from the kernel's as it turns out). > Nice, great to hear that. Pushed as commit d8dab6c3bbe6 ("MIPS/Linux: Correct o32 core file FGR interpretation") now. I hope I didn't make the test case outdated from the beginning. Maciej