From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91614 invoked by alias); 23 May 2018 21:48:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90821 invoked by uid 89); 23 May 2018 21:48:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=greatly, leftover X-HELO: 9pmail.ess.barracuda.com Received: from 9pmail.ess.barracuda.com (HELO 9pmail.ess.barracuda.com) (64.235.150.224) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 May 2018 21:48:05 +0000 Received: from mipsdag02.mipstec.com (mail2.mips.com [12.201.5.32]) by mx26.ess.sfj.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=NO); Wed, 23 May 2018 21:47:03 +0000 Received: from [10.20.78.177] (10.20.78.177) by mipsdag02.mipstec.com (10.20.40.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Wed, 23 May 2018 14:47:03 -0700 Date: Wed, 23 May 2018 23:59:00 -0000 From: "Maciej W. Rozycki" To: Pedro Alves CC: , Djordje Todorovic Subject: Re: [PATCH] testsuite: Extend TLS core file testing with an OS-generated dump In-Reply-To: Message-ID: References: <5b76142d-479d-3c34-9294-9f4510d0fc04@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: mipsdag02.mipstec.com (10.20.40.47) To mipsdag02.mipstec.com (10.20.40.47) X-BESS-ID: 1527112022-853316-30545-263655-1 X-BESS-VER: 2018.6-r1805181819 X-BESS-Apparent-Source-IP: 12.201.5.32 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.193296 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status:1 X-SW-Source: 2018-05/txt/msg00633.txt.bz2 Hi Pedro, > > Acknowledged. Given the current situation I cannot afford investing > > any further work into this change, so let's ditch it (and a change to > > gdb.base/auxv.exp to use `use_gdb_stub' I planned to submit next). If I > > find some time after all, then I can revisit the decision later on. > I understand. Let me take it over then. Below's a version using > core_find. > > I also simplified the patch a bit: > > - Removed the rlimit bits, since it seems that no other core-related test > does that (so it seems to me that if needed, it would better be done > separately and to several testcases at once). Well, I took them from gdb.base/auxv.c, so clearly there's at least one test that has them. Perhaps you could modernise gdb.base/auxv.exp too? > As a local hack, I flipped the logic in: > set core_supported [expr {$corefile != ""}] > to make sure that the expected UNSUPPORTED messages come out. > > Let me know what you think. I'd keep that: rename tls_core_test "" command that I added at the end though, so as not to clutter the procedure space. Otherwise it'll stay there thoughout the rest of a test suite run (we have some leftover clutter in the testsuite already, which sometimes makes different .exp scripts interact with each other). I ran it native and gdbserver-native, and remote, with correct results. Messages in the commit description need to be updated though, as below: > This adds: > > PASS: gdb.threads/tls-core.exp: set cwd to temporary directory for core dumps > PASS: gdb.threads/tls-core.exp: continue to signal > PASS: gdb.threads/tls-core.exp: continue to termination > PASS: gdb.threads/tls-core.exp: generate native core dump > PASS: gdb.threads/tls-core.exp: load native corefile > PASS: gdb.threads/tls-core.exp: print thread-local storage variable from native corefile PASS: gdb.threads/tls-core.exp: native: load core file PASS: gdb.threads/tls-core.exp: native: print thread-local storage variable here, and: > to local testing and: > > UNSUPPORTED: gdb.threads/tls-core.exp: generate native core dump > UNSUPPORTED: gdb.threads/tls-core.exp: load native corefile > UNSUPPORTED: gdb.threads/tls-core.exp: print thread-local storage variable from native corefile WARNING: can't generate a core file - core tests suppressed - check ulimit -c UNSUPPORTED: gdb.threads/tls-core.exp: native: load core file UNSUPPORTED: gdb.threads/tls-core.exp: native: print thread-local storage variable here. Will you handle all this or shall I? Many thanks for taking care of this. Your updated test script actually helped me greatly with a test case for the next change I am going to push (another MIPS/Linux core file mishandling -- we live in a reality separate from the kernel's as it turns out). Maciej