Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@mips.com>
To: Pedro Alves <palves@redhat.com>
Cc: Andrew Burgess <andrew.burgess@embecosm.com>,
	<gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] gdb/testsuite: Handle targets with lots of registers
Date: Fri, 13 Apr 2018 13:57:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.00.1804131425230.11756@tp.orcam.me.uk> (raw)
In-Reply-To: <4273f7eb-464a-3abc-fc50-b6598ed3b896@redhat.com>

On Fri, 13 Apr 2018, Pedro Alves wrote:

> So I'd suggest something like this:
> 
> set saw_registers 0
> set test "maint print registers"
> gdb_test_multiple $test $test {
>     -re "^\[^\r\n\]+\[0-9\]+\[^\r\n\]+\[0-9\]+\[^\r\n\]+\[0-9\]+\[^\r\n\]+\[0-9\]+\[^\r\n\]+\[\r\n\]+" {
>         set saw_registers 1
> 	exp_continue
>     }
>     -re "$gdb_prompt $" {
> 	gdb_assert $saw_registers $test
>     }
> }
> 
> The "saw_registers" bit ends up serving as replacement for
> seeing the heading, though you can also add a pattern to 
> match the heading and check it in the gdb_assert instead if
> you'd like.

 FWIW I think we should keep the heading check.

  Maciej


  reply	other threads:[~2018-04-13 13:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09 15:15 [PATCH 0/3] Small testsuite updates Andrew Burgess
2018-04-09 15:15 ` [PATCH 2/3] gdb/testsuite: Filter out some registers for riscv Andrew Burgess
2018-04-09 21:28   ` Palmer Dabbelt
2018-04-09 22:26     ` Andrew Burgess
2018-04-10 20:25       ` Palmer Dabbelt
2018-04-13 12:55         ` Pedro Alves
2018-04-09 15:15 ` [PATCH 1/3] gdb/testsuite: Fix broken regexp in gdbstub case Andrew Burgess
2018-04-13 12:12   ` Pedro Alves
2018-05-03 19:41     ` Andrew Burgess
2018-05-04  9:18       ` Pedro Alves
2018-04-09 15:15 ` [PATCH 3/3] gdb/testsuite: Handle targets with lots of registers Andrew Burgess
2018-04-12 23:40   ` Maciej W. Rozycki
2018-04-13 13:10     ` Pedro Alves
2018-04-13 13:57       ` Maciej W. Rozycki [this message]
2018-05-04 12:01         ` Andrew Burgess
2018-05-04 12:47           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1804131425230.11756@tp.orcam.me.uk \
    --to=macro@mips.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox