From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9076 invoked by alias); 28 Feb 2018 15:55:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9061 invoked by uid 89); 28 Feb 2018 15:55:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: 9pmail.ess.barracuda.com Received: from 9pmail.ess.barracuda.com (HELO 9pmail.ess.barracuda.com) (64.235.150.225) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Feb 2018 15:55:54 +0000 Received: from MIPSMAIL01.mipstec.com (mailrelay.mips.com [12.201.5.28]) by mx3.ess.sfj.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NO); Wed, 28 Feb 2018 15:55:47 +0000 Received: from [10.20.78.147] (10.20.78.147) by mips01.mipstec.com (10.20.43.31) with Microsoft SMTP Server id 14.3.361.1; Wed, 28 Feb 2018 07:15:37 -0800 Date: Wed, 28 Feb 2018 15:55:00 -0000 From: "Maciej W. Rozycki" To: "Metzger, Markus T" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace target method In-Reply-To: Message-ID: References: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> <1516976072-19282-6-git-send-email-markus.t.metzger@intel.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-BESS-ID: 1519833346-298554-2412-76754-6 X-BESS-VER: 2018.2-r1802232356 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.190516 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status:1 X-SW-Source: 2018-02/txt/msg00461.txt.bz2 Hi Markus, > I wondered why my fill-column auto-mode settings didn't seem to be effective and found > that they were overwritten by gdb/.dir-locals.el. > > If you want to enforce the 74 columns limit, you may want to submit the below patch. I don't use Emacs so I can't comment on technical details of your change, although at the high level it does look reasonable to me. > I will leave the fill-column 74 for the commit-message but fall back to 80 columns for the rest. > IIUC you were mostly concerned about the additional 4-columns indentation by 'git log'. > Are you OK with that? As I say we have the formatting rules set as documented in our wiki, so please do follow them, or if you want to get them changed, then you need to reach consensus about your proposal among GDB maintainers. Maciej