From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80284 invoked by alias); 27 Feb 2018 15:32:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80274 invoked by uid 89); 27 Feb 2018 15:32:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: 9pmail.ess.barracuda.com Received: from 9pmail.ess.barracuda.com (HELO 9pmail.ess.barracuda.com) (64.235.154.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Feb 2018 15:32:01 +0000 Received: from MIPSMAIL01.mipstec.com (mailrelay.mips.com [12.201.5.28]) by mx1402.ess.rzc.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NO); Tue, 27 Feb 2018 15:31:03 +0000 Received: from [10.20.78.126] (10.20.78.126) by mips01.mipstec.com (10.20.43.31) with Microsoft SMTP Server id 14.3.361.1; Tue, 27 Feb 2018 06:57:09 -0800 Date: Tue, 27 Feb 2018 15:32:00 -0000 From: "Maciej W. Rozycki" To: "Metzger, Markus T" CC: Andreas Arnez , "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace target method In-Reply-To: Message-ID: References: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> <1516976072-19282-6-git-send-email-markus.t.metzger@intel.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-BESS-ID: 1519745463-321458-14880-14941-4 X-BESS-VER: 2018.2-r1802232356 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.190477 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status:1 X-SW-Source: 2018-02/txt/msg00425.txt.bz2 Hi Markus, > https://sourceware.org/ml/gdb-patches/2018-02/msg00420.html > > > It's the same I sent inline to the email with a recurring white-space > error fixed. With the change description you have also overrun our 74-column limit: . NB due to how `git log' etc. indents descriptions I prefer to stay within 72 columns with my own changes for a better visual effect, though you are of course free to use your own judgement here as long as you're within 74 columns. Same with ChangeLog entries. Also as per the the GNU Coding Standard: long function lists, etc. use `)' as the closing character, so: * target.h (target_enable_btrace, target_disable_btrace) (target_read_btrace, target_read_btrace_conf): Turn macro into inline function. Throw error if target method not defined. You need to mark new error messages for translation, so: + error (_("Target does not support branch tracing.")); etc. This: +static inline int +target_read_btrace (struct btrace_target_info *tinfo, struct buffer *buffer, + enum btrace_read_type type) also overruns the 74-column limit. The formatting appears otherwise OK to me and I'll leave the matter itself of this change up to someone with suitable expertise in this area. > Andreas already indicated that the patch fixes the problem on s390x. Did the full > test show any further issues on your side, Maciej? We had a failure last night in the lab literally as I have scheduled the tests and consequently they didn't run. I'll schedule them again as soon as possible, but the target system I have been using for testing is not back up yet, so it may not happen before tomorrow. Sorry. > > Also did you verify that old-GDB/new-gdbserver and new-GDB/old-gdbserver > > combinations work correctly? > > That was discussed here: > https://sourceware.org/ml/gdb-patches/2018-02/msg00117.html Thanks for confirming. Is there going to be any difference here for non-x86 targets that needs to be verified? Maciej