From: "Maciej W. Rozycki" <macro@mips.com>
To: Pedro Alves <palves@redhat.com>
Cc: Djordje Todorovic <djordje.todorovic@rt-rk.com>,
<binutils@sourceware.org>, <gdb-patches@sourceware.org>,
"nemanja.popov@rt-rk.com" <nemanja.popov@rt-rk.com>,
<petar.jovanovic@rt-rk.com>,
"Ananthakrishna Sowda (asowda)" <asowda@cisco.com>,
Nikola Prica <nikola.prica@rt-rk.com>
Subject: [committed v7 2/3] BFD: Extract PID from MIPS core dump file
Date: Wed, 08 Nov 2017 21:24:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1711082104500.10088@tp.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.1711081950430.10088@tp.orcam.me.uk>
From: Djordje Todorovic <djordje.todorovic@rt-rk.com>
On MIPS o32, n32 and n64 platforms, PID information was not
correctly propagated from core dump file to internal GDB
structures. This patch fixes that behavior.
A correct PID is needed by `libthread_db' library supplied with
glibc repository revisions before commit c579f48edba8 ("Remove
cached PID/TID in clone") or released versions before 2.25 for
GDB to fetch value of TLS variable from core file.
bfd/ChangeLog:
* elf32-mips.c (elf32_mips_grok_psinfo): Extract core->pid.
* elf64-mips.c (elf64_mips_grok_psinfo): Likewise.
* elfn32-mips.c (elf32_mips_grok_psinfo): Likewise.
---
bfd/elf32-mips.c | 2 ++
bfd/elf64-mips.c | 2 ++
bfd/elfn32-mips.c | 2 ++
3 files changed, 6 insertions(+)
Index: binutils/bfd/elf32-mips.c
===================================================================
--- binutils.orig/bfd/elf32-mips.c 2017-11-08 21:05:36.456371632 +0000
+++ binutils/bfd/elf32-mips.c 2017-11-08 21:05:37.530049782 +0000
@@ -2353,6 +2353,8 @@ elf32_mips_grok_psinfo (bfd *abfd, Elf_I
return FALSE;
case 128: /* Linux/MIPS elf_prpsinfo */
+ elf_tdata (abfd)->core->pid
+ = bfd_get_32 (abfd, note->descdata + 16);
elf_tdata (abfd)->core->program
= _bfd_elfcore_strndup (abfd, note->descdata + 32, 16);
elf_tdata (abfd)->core->command
Index: binutils/bfd/elf64-mips.c
===================================================================
--- binutils.orig/bfd/elf64-mips.c 2017-11-08 21:05:36.474538851 +0000
+++ binutils/bfd/elf64-mips.c 2017-11-08 21:05:37.538147336 +0000
@@ -4228,6 +4228,8 @@ elf64_mips_grok_psinfo (bfd *abfd, Elf_I
return FALSE;
case 136: /* Linux/MIPS - N64 kernel elf_prpsinfo */
+ elf_tdata (abfd)->core->pid
+ = bfd_get_32 (abfd, note->descdata + 24);
elf_tdata (abfd)->core->program
= _bfd_elfcore_strndup (abfd, note->descdata + 40, 16);
elf_tdata (abfd)->core->command
Index: binutils/bfd/elfn32-mips.c
===================================================================
--- binutils.orig/bfd/elfn32-mips.c 2017-11-08 21:05:36.489887759 +0000
+++ binutils/bfd/elfn32-mips.c 2017-11-08 21:05:37.562322680 +0000
@@ -3562,6 +3562,8 @@ elf32_mips_grok_psinfo (bfd *abfd, Elf_I
return FALSE;
case 128: /* Linux/MIPS elf_prpsinfo */
+ elf_tdata (abfd)->core->pid
+ = bfd_get_32 (abfd, note->descdata + 16);
elf_tdata (abfd)->core->program
= _bfd_elfcore_strndup (abfd, note->descdata + 32, 16);
elf_tdata (abfd)->core->command
next prev parent reply other threads:[~2017-11-08 21:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 13:47 [PATCH 0/3] Fix issues with writing Linux core PRSTATUS note on MIPS o32, n32 and n64 into core file Djordje Todorovic
2017-10-17 13:55 ` Maciej W. Rozycki
2017-10-17 13:57 ` Djordje Todorovic
2017-10-25 14:15 ` Djordje Todorovic
2017-10-25 22:40 ` Maciej W. Rozycki
2017-10-26 11:22 ` Djordje Todorovic
2017-10-30 13:44 ` Maciej W. Rozycki
2017-10-30 14:12 ` Maciej W. Rozycki
2017-11-03 13:05 ` Djordje Todorovic
2017-11-07 21:59 ` Maciej W. Rozycki
2017-11-08 10:10 ` Pedro Alves
2017-11-08 21:23 ` Maciej W. Rozycki
2017-11-08 21:24 ` [committed v7 1/3] BFD: Write Linux core PRSTATUS note into MIPS " Maciej W. Rozycki
2017-11-08 21:24 ` Maciej W. Rozycki [this message]
2017-11-08 21:26 ` [committed v7 3/3] Add test for fetching TLS from " Maciej W. Rozycki
2017-11-09 10:32 ` [PATCH 0/3] Fix issues with writing Linux core PRSTATUS note on MIPS o32, n32 and n64 into " Djordje Todorovic
2017-11-09 22:41 ` Maciej W. Rozycki
2017-11-07 21:31 ` Maciej W. Rozycki
2017-11-08 9:56 ` Pedro Alves
2017-11-08 18:41 ` Maciej W. Rozycki
2017-10-27 15:00 ` Pedro Alves
2017-10-30 13:38 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1711082104500.10088@tp.orcam.me.uk \
--to=macro@mips.com \
--cc=asowda@cisco.com \
--cc=binutils@sourceware.org \
--cc=djordje.todorovic@rt-rk.com \
--cc=gdb-patches@sourceware.org \
--cc=nemanja.popov@rt-rk.com \
--cc=nikola.prica@rt-rk.com \
--cc=palves@redhat.com \
--cc=petar.jovanovic@rt-rk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox