From: "Maciej W. Rozycki" <macro@mips.com>
To: Djordje Todorovic <djordje.todorovic@rt-rk.com>
Cc: <binutils@sourceware.org>, <gdb-patches@sourceware.org>,
<asowda@cisco.com>, <petar.jovanovic@rt-rk.com>,
<nemanja.popov@rt-rk.com>, <nikola.prica@rt-rk.com>,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH 1/3] BFD: Write Linux core PRSTATUS note into MIPS core file
Date: Wed, 25 Oct 2017 22:41:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1710252219080.3886@tp.orcam.me.uk> (raw)
In-Reply-To: <1508940933-13857-1-git-send-email-djordje.todorovic@rt-rk.com>
On Wed, 25 Oct 2017, Djordje Todorovic wrote:
> diff --git a/bfd/elf32-mips.c b/bfd/elf32-mips.c
> index 17ca432..69c6061 100644
> --- a/bfd/elf32-mips.c
> +++ b/bfd/elf32-mips.c
> @@ -2554,6 +2593,9 @@ static const struct ecoff_debug_swap mips_elf32_ecoff_debug_swap = {
> #define ELF_COMMONPAGESIZE 0x1000
> #define elf32_bed elf32_tradbed
>
> +#undef elf_backend_write_core_note
> +#define elf_backend_write_core_note elf32_mips_write_core_note
This is column #48 rather than #40 (compare the `elf32_bed' definition
above and the preceding ones). Likewise the two other places. I'll fix
it up myself when committing though, no need to resubmit.
Maciej
next prev parent reply other threads:[~2017-10-25 22:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 14:15 Djordje Todorovic
2017-10-25 14:15 ` [PATCH 3/3] Add test for fetching TLS from " Djordje Todorovic
2017-10-25 14:15 ` [PATCH 2/3] BFD: Extract PID from MIPS core dump file Djordje Todorovic
2017-10-25 22:41 ` Maciej W. Rozycki [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-17 13:50 [PATCH 1/3] BFD: Write Linux core PRSTATUS note into MIPS core file Djordje Todorovic
2017-10-18 13:36 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1710252219080.3886@tp.orcam.me.uk \
--to=macro@mips.com \
--cc=asowda@cisco.com \
--cc=binutils@sourceware.org \
--cc=djordje.todorovic@rt-rk.com \
--cc=gdb-patches@sourceware.org \
--cc=nemanja.popov@rt-rk.com \
--cc=nikola.prica@rt-rk.com \
--cc=palves@redhat.com \
--cc=petar.jovanovic@rt-rk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox