From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: <binutils@sourceware.org>, <gdb-patches@sourceware.org>,
Pedro Alves <palves@redhat.com>,
Djordje Todorovic <djordje.todorovic@rt-rk.com>
Subject: Re: [PATCH 3/4] ELF/BFD: Handle both variants of the 64-bit Linux core PRPSINFO note
Date: Sun, 24 Sep 2017 22:19:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1709242231080.16752@tp.orcam.me.uk> (raw)
In-Reply-To: <878th6xj8q.fsf@redhat.com>
On Sat, 23 Sep 2017, Sergio Durigan Junior wrote:
> I noticed that you put the most common definition at the top in the
> previous patch (32-bit), but now you're putting the most common at the
> bottom. I'd prefer if you could put the most common at the top and the
> specific one at the bottom for both 32- and 64-bit cases.
I placed both 32-bit UID/GID versions ahead of their respective 16-bit
counterparts, recognising that the 32-bit versions are the default in BFD,
which in turns follows Linux's <asm-generic/posix_types.h> default. The
32-bit UID/GID versions are also the predominant choice in Linux, for both
32-bit ports (ARC, Blackfin, TI C6X, H8/300, Hexagon*, Meta, MicroBlaze,
MIPS, Nios II, OpenRISC, PA-RISC, PowerPC, TILE, UniCore-32*, Xtensa) and
64-bit ports (all except SuperH).
I hope it clarifies my choice and I think it makes sense this way.
Maciej
[*] Binutils port not upstream.
next prev parent reply other threads:[~2017-09-24 22:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 0:02 [PATCH 0/4] Fix issues with Linux core PRPSINFO note definitions Maciej W. Rozycki
2017-09-23 0:03 ` [PATCH 1/4] ELF/BFD: Fix padding in `elf_external_linux_prpsinfo64' Maciej W. Rozycki
2017-09-23 0:04 ` [PATCH 3/4] ELF/BFD: Handle both variants of the 64-bit Linux core PRPSINFO note Maciej W. Rozycki
2017-09-23 2:05 ` Sergio Durigan Junior
2017-09-24 22:19 ` Maciej W. Rozycki [this message]
2017-09-24 23:32 ` Sergio Durigan Junior
2017-09-25 9:48 ` Maciej W. Rozycki
2017-09-25 16:49 ` Sergio Durigan Junior
2017-09-23 0:04 ` [PATCH 2/4] ELF/BFD,GDB: Handle both variants of the 32-bit " Maciej W. Rozycki
2017-09-23 0:05 ` [PATCH 4/4] GDB: Remove Linux core PRPSINFO note writer override Maciej W. Rozycki
2017-09-23 2:10 ` [PATCH 0/4] Fix issues with Linux core PRPSINFO note definitions Sergio Durigan Junior
2017-09-24 23:46 ` Alan Modra
2017-09-29 21:11 ` [PING][PATCH " Maciej W. Rozycki
2017-10-11 0:32 ` [PING^2][PATCH " Maciej W. Rozycki
2017-10-11 9:41 ` Pedro Alves
2017-10-11 14:06 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1709242231080.16752@tp.orcam.me.uk \
--to=macro@imgtec.com \
--cc=binutils@sourceware.org \
--cc=djordje.todorovic@rt-rk.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox