Re: [PATCH 0/4] Fix issues with Linux core PRPSINFO note definitions

Sergio Durigan Junior
2017-09-23T02:10:04Z

On Friday, September 22 2017, Maciej W. Rozycki wrote:

> Hi,
>
> This patch series addresses problems with Linux core PRPSINFO note
> definitions, discovered in the course of Djordje's MIPS PID extraction
> patch review. See individual patch descriptions for details.
>
> These changes have passed binutils regression testing against my usual
> targets (for the BFD part) and also native GDB regression testing with the
> `x86_64-linux-gnu' target and the `mips-linux-gnu' n64 target (for the GDB
> part, and the `gcore' command in particular).
>
> OK to apply?

Hey Maciej,

Aside from a small nit on patch #3, I really like the direction you
chose on this patch. I am not a binutils maintainer and not a GDB
global maintainer, so I cannot approve it, but it does look good to me
and makes the existing code more logical and simpler to follow.

I also like the fact that you removed the responsibility that GDB had to
decide which prpsinfo structure it would use. That's something I
remember struggling with when I was hacking the initial patch, and I'm
glad this patch solves it.

So, LGTM.

Thanks,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible