From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-140811-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 90644 invoked by alias); 7 Aug 2017 15:15:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 90492 invoked by uid 89); 7 Aug 2017 15:15:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mailapp01.imgtec.com
Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Aug 2017 15:15:40 +0000
Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19])	by Forcepoint Email with ESMTPS id 363D2F11098D5;	Mon,  7 Aug 2017 16:15:34 +0100 (IST)
Received: from [10.20.78.47] (10.20.78.47) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Mon, 7 Aug 2017 16:15:37 +0100
Date: Mon, 07 Aug 2017 15:15:00 -0000
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
CC: Alan Modra <amodra@gmail.com>, Binutils <binutils@sourceware.org>, GDB	<gdb-patches@sourceware.org>, Yao Qi <qiyaoltc@gmail.com>
Subject: Re: [PATCH] GDB/opcodes: Remove arch/mach/endian disassembler assertions
In-Reply-To: <CAMe9rOoCG+pJ2aBfoT3SyYNj2TgiBz7xOhmMBrGbhpnac++gQQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.00.1708071613160.17596@tp.orcam.me.uk>
References: <alpine.DEB.2.00.1708010044560.29991@tp.orcam.me.uk> <20170807132424.GF3406@bubble.grove.modra.org> <alpine.DEB.2.00.1708071556260.17596@tp.orcam.me.uk> <CAMe9rOoCG+pJ2aBfoT3SyYNj2TgiBz7xOhmMBrGbhpnac++gQQ@mail.gmail.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
X-SW-Source: 2017-08/txt/msg00127.txt.bz2

On Mon, 7 Aug 2017, H.J. Lu wrote:

> I am checking in:
> 
> diff --git a/opcodes/disassemble.c b/opcodes/disassemble.c
> index 0058354265..11206c67a5 100644
> --- a/opcodes/disassemble.c
> +++ b/opcodes/disassemble.c
> @@ -110,7 +110,9 @@
>  #endif
> 
>  disassembler_ftype
> -disassembler (enum bfd_architecture a, bfd_boolean big, unsigned long mach,
> +disassembler (enum bfd_architecture a,
> +        bfd_boolean big ATTRIBUTE_UNUSED,
> +        unsigned long mach ATTRIBUTE_UNUSED,
>          bfd *abfd ATTRIBUTE_UNUSED)
>  {
>    disassembler_ftype disassemble;
> 
> to fix
> 
> /export/gnu/import/git/sources/binutils-gdb/opcodes/disassemble.c: In
> function ‘disassembler’:
> /export/gnu/import/git/sources/binutils-gdb/opcodes/disassemble.c:113:52:
> error: unused parameter ‘big’ [-Werror=unused-parameter]
>  disassembler (enum bfd_architecture a, bfd_boolean big, unsigned long mach,
>                                                     ^~~
> /export/gnu/import/git/sources/binutils-gdb/opcodes/disassemble.c:113:71:
> error: unused parameter ‘mach’ [-Werror=unused-parameter]
>  disassembler (enum bfd_architecture a, bfd_boolean big, unsigned long mach,
>                                                                        ^~~~
> cc1: all warnings being treated as errors
> make[6]: *** [Makefile:1313: disassemble.lo] Error 1
> 
> on x86.

 Thanks, and sorry for the breakage.  I only verified it with 
`--enable-targets=all', but should have run full binutils testing across 
my usual targets.

  Maciej