From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94933 invoked by alias); 28 Oct 2016 19:44:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94919 invoked by uid 89); 28 Oct 2016 19:44:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=pmo, PMO X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Oct 2016 19:44:45 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id 8ED9B865D2410; Fri, 28 Oct 2016 20:44:38 +0100 (IST) Received: from [10.20.78.230] (10.20.78.230) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Fri, 28 Oct 2016 20:44:41 +0100 Date: Fri, 28 Oct 2016 19:44:00 -0000 From: "Maciej W. Rozycki" To: Pedro Alves CC: Yao Qi , Subject: Re: [PATCH 07/13] Split brekapoint_from_pc to breakpoint_kind_from_pc and sw_breakpoint_from_kind In-Reply-To: <8b3bfe2b-c4ea-176d-4647-fed605e09004@redhat.com> Message-ID: References: <1472655965-12212-1-git-send-email-yao.qi@linaro.org> <1472655965-12212-8-git-send-email-yao.qi@linaro.org> <8b3bfe2b-c4ea-176d-4647-fed605e09004@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2016-10/txt/msg00825.txt.bz2 On Thu, 27 Oct 2016, Pedro Alves wrote: > > + case MIPS_BP_KIND_32BIT: > > + { > > + /* The IDT board uses an unusual breakpoint value, and > > + sometimes gets confused when it sees the usual MIPS > > + breakpoint instruction. */ > > + static gdb_byte big_breakpoint[] = { 0, 0x5, 0, 0xd }; > > + static gdb_byte little_breakpoint[] = { 0xd, 0, 0x5, 0 }; > > + static gdb_byte pmon_big_breakpoint[] = { 0, 0, 0, 0xd }; > > + static gdb_byte pmon_little_breakpoint[] = { 0xd, 0, 0, 0 }; > > + static gdb_byte idt_big_breakpoint[] = { 0, 0, 0x0a, 0xd }; > > + static gdb_byte idt_little_breakpoint[] = { 0xd, 0x0a, 0, 0 }; > > + /* Likewise, IRIX appears to expect a different breakpoint, > > + although this is not apparent until you try to use pthreads. */ > > + static gdb_byte irix_big_breakpoint[] = { 0, 0, 0, 0xd }; > > + > > + *size = 4; > > + > > + if (strcmp (target_shortname, "mips") == 0) > > + { > > + if (byte_order_for_code == BFD_ENDIAN_BIG) > > + return idt_big_breakpoint; > > + else > > + return idt_little_breakpoint; > > + } > > + else if (strcmp (target_shortname, "ddb") == 0 > > + || strcmp (target_shortname, "pmon") == 0 > > + || strcmp (target_shortname, "lsi") == 0) > > + { > > + if (byte_order_for_code == BFD_ENDIAN_BIG) > > + return pmon_big_breakpoint; > > + else > > + return pmon_little_breakpoint; > > + } > > + else if (gdbarch_osabi (gdbarch) == GDB_OSABI_IRIX) > > + return irix_big_breakpoint; > > FYI, I think all of these above could be removed. > target mips/ddb/pmon/etc. are all gone, and we don't support IRIX any > longer either: > > *** Changes in GDB 7.12*** Changes in GDB 7.12 > > * Support for various remote target protocols and ROM monitors has > been removed: > > target m32rsdi Remote M32R debugging over SDI > target mips MIPS remote debugging protocol > target pmon PMON ROM monitor > target ddb NEC's DDB variant of PMON for Vr4300 > target rockhopper NEC RockHopper variant of PMON > target lsi LSI variant of PMO > > *** Changes in GDB 7.10 > > Support for these obsolete configurations has been removed. > > SGI Irix-5.x mips-*-irix5* > SGI Irix-6.x mips-*-irix6* Agreed, all this can go. I'd prefer changes to be functionally self-contained though, so I'm working right now on a set of preparatory changes to remove the remains of MIPS target-side support for IRIX and legacy remote protocols. I'll post the patches shortly. Please rebase this change on top. Maciej