From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89229 invoked by alias); 18 Oct 2016 03:50:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89073 invoked by uid 89); 18 Oct 2016 03:50:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=interest X-HELO: mailapp01.imgtec.com Received: from mailapp02.imgtec.com (HELO mailapp01.imgtec.com) (217.156.133.132) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Oct 2016 03:50:24 +0000 Received: from HHMAIL03.hh.imgtec.org (unknown [10.44.0.21]) by Forcepoint Email with ESMTPS id ED0F12F2C87C8; Tue, 18 Oct 2016 04:50:19 +0100 (IST) Received: from HHMAIL01.hh.imgtec.org (10.100.10.19) by HHMAIL03.hh.imgtec.org (10.44.0.21) with Microsoft SMTP Server (TLS) id 14.3.294.0; Tue, 18 Oct 2016 04:50:21 +0100 Received: from [10.20.78.147] (10.20.78.147) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Tue, 18 Oct 2016 04:50:20 +0100 Date: Tue, 18 Oct 2016 03:50:00 -0000 From: "Maciej W. Rozycki" To: Pedro Alves CC: Subject: Re: [PATCH] tilegx-tdep: Correct aliasing errors in `tilegx_analyze_prologue' In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2016-10/txt/msg00501.txt.bz2 On Mon, 17 Oct 2016, Pedro Alves wrote: > > Fix a load of aliasing build errors: > > > > cc1plus: warnings being treated as errors > > .../gdb/tilegx-tdep.c: In function 'CORE_ADDR tilegx_analyze_prologue(gdbarch*, CORE_ADDR, CORE_ADDR, tilegx_frame_cache*, frame_info*)': > > .../gdb/tilegx-tdep.c:609: error: dereferencing pointer 'operands' does break strict-aliasing rules > > .../gdb/tilegx-tdep.c:592: error: dereferencing pointer 'operands' does break strict-aliasing rules > > .../gdb/tilegx-tdep.c:571: error: dereferencing pointer 'operands' does break strict-aliasing rules > > [...] > > .../gdb/tilegx-tdep.c:601: error: dereferencing pointer '' does break strict-aliasing rules > > .../gdb/tilegx-tdep.c:601: note: initialized from here > > cc1plus: error: dereferencing pointer 'operands' does break strict-aliasing rules > > cc1plus: error: dereferencing pointer 'operands' does break strict-aliasing rules > > .../gdb/tilegx-tdep.c:452: note: initialized from here > > cc1plus: error: dereferencing pointer 'pretmp.896' does break strict-aliasing rules > > cc1plus: note: initialized from here > > cc1plus: error: dereferencing pointer 'pretmp.896' does break strict-aliasing rules > > cc1plus: note: initialized from here > > make[1]: *** [tilegx-tdep.o] Error 1 > > > > from an attempt to cast a `long long' pointer to an `int64_t' pointer, > > which may not necessarily be compatible types. Use the `long long' type > > for the auxiliary variable then as this is the type of the structure > > member referred. > > > > gdb/ > > * tilegx-tdep.c (tilegx_analyze_prologue): Use the `long long' > > type for `operands'. > > --- > > Hi, > > > > This was discovered in an `--enable-targets=all' `mips-mti-linux-gnu' > > build and may be dependent on the host type and compiler version, which > > are `x86_64-linux' and 4.4.7 here, respectively. OK to apply? > > > > Sure, please do ahead. > > I'd be better if tilegx.h used uint32_t/uint64_t, etc, > but that can always be done separately by someone motivated. The issue there is `tilegx.h' is shared with binutils which have not yet moved past C89 I believe. Of course the use of `long long' is already non-C89, however it's been there with some C89 compilers before `stdint.h' types have been introduced. We could use `bfd_uint64_t' instead, but that would make `tilegx.h' depend on a BFD header. So it's not an obvious call and therefore I agree it's best left to someone who has an actual interest with the target. Committed now, thanks for your review. Maciej