From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Pedro Alves <palves@redhat.com>
Cc: Bhushan Attarde <Bhushan.Attarde@imgtec.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Matthew Fortune <Matthew.Fortune@imgtec.com>,
James Hogan <James.Hogan@imgtec.com>,
Andrew Bennett <Andrew.Bennett@imgtec.com>,
Jaydeep Patil <Jaydeep.Patil@imgtec.com>
Subject: Re: [PATCH 0/24] MIPS: Add support for reconfigurable FPR size, MIPS MSA and MIPSR6,support
Date: Tue, 04 Oct 2016 18:14:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.00.1610041856300.11928@tp.orcam.me.uk> (raw)
In-Reply-To: <dd334b57-8a72-153d-c638-c5e6a62a7cbd@redhat.com>
On Tue, 4 Oct 2016, Pedro Alves wrote:
> > Finally please note that I cannot approve changes outside the MIPS
> > target, but to speed up the process I'll check them regardless to see if
> > there are any obvious issues. You'll still have to seek a global
> > maintainer's approval for those changes though.
>
> I can't speak for others, but at least I was waiting for a
> repost and for Maciej to validate the overall idea.
After numerous hiccups and distractions I am about to get back to this
review.
For the record -- I have come across an inconsistency in FCR handling,
coming from a regression introduced with XML description support for the
MIPS target, affecting this patch series. I am about to commit a fix,
after the final testing I'm still working on; I'd like to see it there in
7.12 so that we have a fixed proper release before MSA goes in. Code in
the patch set will then have to be adjusted accordingly.
Parts of some patches apply to binutils rather than GDB and need to be
split, so I'll go through the series as they are so that there is no need
to proliferate reposts unnecessarily.
> Also, for some reason, neither I nor the mailing list archives
> seem to have received the whole patch set:
>
> https://sourceware.org/ml/gdb-patches/2016-06/msg00510.html
There has been an issue with this submission indeed in that it arrived as
two separate threads, but the remaining patches do have made it there:
https://sourceware.org/ml/gdb-patches/2016-06/msg00425.html
> FYI, in case a global-maintainer review was the blocker here.
I don't think so, not at this stage. We need to sort out the general
structure of the patch set first. Please feel free, or indeed anyone
else, to chime in if you like, of course.
Maciej
prev parent reply other threads:[~2016-10-04 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9D3E5517712EFA419C6B9C50EDC1282CAA1FA536@PUMAIL01.pu.imgtec.org>
2016-07-25 13:58 ` Maciej W. Rozycki
2016-10-04 17:48 ` Pedro Alves
2016-10-04 18:14 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1610041856300.11928@tp.orcam.me.uk \
--to=macro@imgtec.com \
--cc=Andrew.Bennett@imgtec.com \
--cc=Bhushan.Attarde@imgtec.com \
--cc=James.Hogan@imgtec.com \
--cc=Jaydeep.Patil@imgtec.com \
--cc=Matthew.Fortune@imgtec.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox