From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-132752-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 61284 invoked by alias); 25 Jul 2016 13:36:05 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 60354 invoked by uid 89); 25 Jul 2016 13:36:04 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:586, preferable, H*r:0100, noisy
X-HELO: mailapp01.imgtec.com
Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Jul 2016 13:36:03 +0000
Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19])	by Forcepoint Email with ESMTPS id 35CEA21DF93E9;	Mon, 25 Jul 2016 14:35:48 +0100 (IST)
Received: from [10.20.78.138] (10.20.78.138) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Mon, 25 Jul 2016 14:35:50 +0100
Date: Mon, 25 Jul 2016 13:36:00 -0000
From: "Maciej W. Rozycki" <macro@imgtec.com>
To: Tom Tromey <tom@tromey.com>
CC: Yao Qi <qiyaoltc@gmail.com>, "gdb-patches@sourceware.org"	<gdb-patches@sourceware.org>
Subject: Re: [RFA 5/6] Remove unused variables
In-Reply-To: <87twfkks44.fsf@tromey.com>
Message-ID: <alpine.DEB.2.00.1607251434540.4076@tp.orcam.me.uk>
References: <1465248812-23902-1-git-send-email-tom@tromey.com> <1465248812-23902-6-git-send-email-tom@tromey.com> <CAH=s-PMvtHAGGy-DQb_0qFRwuxfrg724i_yY3+qJzYnqgjixhQ@mail.gmail.com> <87wpl9t4l2.fsf@tromey.com> <CAH=s-PN+RJyhxRAgqM05hW97cTMzAn_rUQutxfJDrAJHPm-RqQ@mail.gmail.com> <87furdnubd.fsf@tromey.com> <alpine.DEB.2.00.1607201848070.4076@tp.orcam.me.uk> <87twfkks44.fsf@tromey.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-SW-Source: 2016-07/txt/msg00329.txt.bz2

On Wed, 20 Jul 2016, Tom Tromey wrote:

> Maciej>  Of course one could argue that keeping broken code (though in a manner 
> Maciej> harmless to irrelevant cases) has little value, but at least it serves as 
> Maciej> a reminder to do something about it sometime.
> 
> I think on the whole it's preferable to file a bug for such cases; or to
> comment out the offending code and put in an explanation.  The warnings
> catch real bugs; but they are not as useful if they are noisy.

 Good point, I have filed PR tdep/20406 to track this issue.

  Maciej