From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12009 invoked by alias); 25 Jul 2016 13:58:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11974 invoked by uid 89); 25 Jul 2016 13:58:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=III, availability, notes, H*Ad:D*imgtec.com X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Jul 2016 13:58:41 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id 559982E48122A for ; Mon, 25 Jul 2016 14:58:25 +0100 (IST) Received: from [10.20.78.138] (10.20.78.138) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.294.0; Mon, 25 Jul 2016 14:58:27 +0100 Date: Mon, 25 Jul 2016 13:58:00 -0000 From: "Maciej W. Rozycki" To: Bhushan Attarde CC: "gdb-patches@sourceware.org" , Matthew Fortune , James Hogan , Andrew Bennett , Jaydeep Patil Subject: Re: [PATCH 0/24] MIPS: Add support for reconfigurable FPR size, MIPS MSA and MIPSR6,support In-Reply-To: <9D3E5517712EFA419C6B9C50EDC1282CAA1FA536@PUMAIL01.pu.imgtec.org> Message-ID: References: <9D3E5517712EFA419C6B9C50EDC1282CAA1FA536@PUMAIL01.pu.imgtec.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 8BIT X-SW-Source: 2016-07/txt/msg00331.txt.bz2 Bhushan, First of all thank you for your submission, and also apologies for the long RTT. Now a couple of general questions/notes: 1. Can you please reformat the e-mails with patches such that they can be readily fed to Git? Using `git format-patch' would be the usual way, although of course feel free to do it however you like. In the form you posted they have leading blanks across descriptions which do not work well with `git am' (see also ). 2. You haven't told us how you verified these changes. Have you run any regression testing at all? If so, the which targets have you tested? Also please make sure that you at least build changes which affect generic files with `--enable-targets=all'. 3. Some changes touch files in the include/ and opcodes/ subdirectories. These (except for include/gdb/) are maintained as a part of the binutils project and need to be posted to the relevant mailing list, which is . I'll review the relevant parts in this round with an appropriate `Cc' added, but please pay attention to have the binutils mailing list included where appropriate in the submission. In fact especially changes to opcodes/ and include/opcode/ appear self-contained and largely independent from the GDB part of the containing patch, so they may best be split off and submitted to the binutils project first. More on this in replies to individual patches. >     1. Handles run-time reconfigurable FPR size. MIPS revision 2 onwards > MIPS32 > >     and MIPS64 both can have either 32-bit or 64-bit FPRs. This is decided > >     based on the values of CP1.FIR.F64, CP0.SR.FR and CP0.Config5.FRE bits. > >     Patch 1 to patch 12 in the series handles this property. This work is > based > >     on the patch submitted earlier by Maciej W. Rozycki. Please refer to > >     https://sourceware.org/ml/gdb-patches/2012-06/msg00201.html for details. > So > >     this series includes his patch (updated to GDB 7.11 release version) as > the > >     [patch 1] of the series. For the record please note that the availability of CP0.Status.FR goes back to the MIPS III ISA and therefore all 64-bit MIPS processors have it. So if you need to determine the presence of this bit, then the algorithm conceptually is (isa_is_64bit || CP1.FIR.F64). This introduction is not going to end up in our Git repository, but for the sake of people's confusion avoidance please update it in patch resubmission. Finally please note that I cannot approve changes outside the MIPS target, but to speed up the process I'll check them regardless to see if there are any obvious issues. You'll still have to seek a global maintainer's approval for those changes though. Maciej