From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39965 invoked by alias); 3 May 2016 14:57:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39939 invoked by uid 89); 3 May 2016 14:57:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=holiday, proceeds, clean-up, bank X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 May 2016 14:57:37 +0000 Received: from hhmail02.hh.imgtec.org (unknown [10.100.10.20]) by Websense Email with ESMTPS id 29DB981A4A8F3; Tue, 3 May 2016 15:57:31 +0100 (IST) Received: from [10.20.78.123] (10.20.78.123) by hhmail02.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server id 14.3.266.1; Tue, 3 May 2016 15:57:33 +0100 Date: Tue, 03 May 2016 14:57:00 -0000 From: "Maciej W. Rozycki" To: Pedro Alves CC: Trevor Saunders , Yao Qi , Subject: Re: [PATCH, doc RFA] Remove support for "target m32rsdi" and "target mips/pmon/ddb/rockhopper/lsi" In-Reply-To: Message-ID: References: <1458230389-28233-1-git-send-email-palves@redhat.com> <8637rivld3.fsf@gmail.com> <56F13269.8020602@redhat.com> <56FD12FE.1030300@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2016-05/txt/msg00037.txt.bz2 On Mon, 2 May 2016, Pedro Alves wrote: > > NB it looks to me `mips_r3041_reg_names' is now dead. We just *might* > > consider rewiring it like `mips_tx39_reg_names', but that would require > > defining another BFD machine type and I doubt anybody cares about the > > R3041 anymore (cf. the relevant comment you've just removed). So if you > > care to remove it too, then I'll appreciate it and a change to do so is > > preapproved. > > > > Given that the variable is static I wonder why it hasn't triggered a > > compilation error in the build actually. > > That's because gdb doesn't use -Wunused presently. Hmm, I thought it was implied by -Wall. Perhaps we should add it then? Releases are built without -Werror so the end users will be safe either way, and it'll make us easier to avoid code pollution. > I never managed to come back to this, and looks like we won't need to. > Trevor sent a patch that removes mips_r3041_reg_names among a ton > of other unused variables, here: > > https://sourceware.org/ml/gdb-patches/2016-04/msg00664.html Great! As it happens, I made a patch to remove `mips_r3041_reg_names' on Friday, but didn't get to actually pushing it -- and we had a bank holiday yesterday. I'll give Trevor's change precedence then as a more general clean-up, although I'd like to review the MIPS part, as not all variables removed from mips-tdep.c are actually "trivially unused" (those would be lone declarations, possibly with initialisers). Especially the heuristic unwinder bits look highly suspicious to me, where the variable is updated as the analysis proceeds. It could be that these variables can indeed go, but perhaps something is missing that should be there. I'll try to get this done by the end of tomorrow. Maciej