From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32697 invoked by alias); 3 Sep 2013 14:58:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32688 invoked by uid 89); 3 Sep 2013 14:58:03 -0000 Received: from ra.se.axis.com (HELO ra.se.axis.com) (195.60.68.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Sep 2013 14:58:03 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: ra.se.axis.com Received: from localhost (localhost [127.0.0.1]) by ra.se.axis.com (Postfix) with ESMTP id 8C14F349611; Tue, 3 Sep 2013 16:58:00 +0200 (CEST) Received: from ra.se.axis.com ([127.0.0.1]) by localhost (ra.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6VmoJNugKKwG; Tue, 3 Sep 2013 16:57:59 +0200 (CEST) Received: from boulder.se.axis.com (boulder.se.axis.com [10.0.2.104]) by ra.se.axis.com (Postfix) with ESMTP id 44F8434960D; Tue, 3 Sep 2013 16:57:59 +0200 (CEST) Received: from boulder.se.axis.com (localhost [127.0.0.1]) by postfix.imss71 (Postfix) with ESMTP id 2EA61606; Tue, 3 Sep 2013 16:57:59 +0200 (CEST) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by boulder.se.axis.com (Postfix) with ESMTP id 2315F218; Tue, 3 Sep 2013 16:57:59 +0200 (CEST) Received: from xmail2.se.axis.com (xmail2.se.axis.com [10.0.5.74]) by thoth.se.axis.com (Postfix) with ESMTP id 2191D3404E; Tue, 3 Sep 2013 16:57:59 +0200 (CEST) Received: from lnxricardw.se.axis.com (10.88.7.1) by xmail2.se.axis.com (10.0.5.74) with Microsoft SMTP Server (TLS) id 8.2.255.0; Tue, 3 Sep 2013 16:57:59 +0200 Date: Tue, 03 Sep 2013 14:58:00 -0000 From: Ricard Wanderlof To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH][CRISv32] Add support for threaded debugging In-Reply-To: <5225F303.4050901@redhat.com> Message-ID: References: <5224D319.1000704@redhat.com> <5225F303.4050901@redhat.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 8BIT X-SW-Source: 2013-09/txt/msg00081.txt.bz2 On Tue, 3 Sep 2013, Pedro Alves wrote: >>> This part looks OK, though it did raise some eyebrows to have >>> GNU/Linux-specific code in cris-tdep.c, rather than in a cris-linux-tdep.c >>> file. It seems there's no real support for cris bare-metal debugging? > ... >> I don't really see the need for it. It doesn't seem like it would be a >> huge effort (essentially the call to >> set_gdbarch_fetch_tls_load_module_address and also >> set_solib_svr4_fetch_link_map_offsets would be put in cris-linux-tdep.c), >> on the other hand I can't really test that it works as expected, > ... > It's mostly about code/design/maintenance sanity. I won't really mind if the > split isn't done, but note how the fact that there's a Linux port here > is being missed often in regular maintenance (because people will look > for *linux-tdep.*) files. cris-tdep.c doesn't call linux_init_abi anywhere > AFAICT, for example, so the cris port lost the adjustment between v1 > and v2 of the gdbarch_gdb_signal_{to,from}_target > patches, just a few weeks back: > > http://sourceware.org/ml/gdb-patches/2013-07/msg00002.html > http://sourceware.org/ml/gdb-patches/2013-07/msg00651.html > > Probably other across-the-board changes have been missed. That's a good point. I'll see if I find some time to make a rudimentary split. Regarding the specific case above, it's a bit odd though that the CRIS port was included in the first patch set but not the second, considering they were supplied by the same person. Still, it still makes your point. /Ricard -- Ricard Wolf Wanderlöf ricardw(at)axis.com Axis Communications AB, Lund, Sweden www.axis.com Phone +46 46 272 2016 Fax +46 46 13 61 30