Re: [PATCH] Fix CRISv32 compilation

Ricard Wanderlof
2013-09-06T08:09:33Z

On Mon, 2 Sep 2013, Pedro Alves wrote:

> On 08/30/2013 02:12 PM, Ricard Wanderlof wrote:
>>
>> 2013-08-30 Ricard Wanderlof <ricardw@axis.com>
>>
>> gdbserver
>>
>> * linux-crisv32-low.c: Fix compilation errors.
>
> Write:
>
> * linux-crisv32-low.c (elf_gregset_t): Delete typedef.
> (initialize_low_arch): Call init_registers_crisv32 rather than
> init_register_crisv32.
>
> OK with that change.
>
> (I can't see how the typedef was breaking the build though)

Comitted now.

/Ricard

Fix compilation for target gdbserver on CRISv32 platform.

One misspelled function call, and one superfluous typedef. The latter
causes an error of the following type when building:

linux-crisv32-low.c:372: error: conflicting types for 'elf_gregset_t'
/.../target/include/asm/elf.h:36:
error: previous declaration of 'elf_gregset_t' was here

2013-09-06 Ricard Wanderlof <ricardw@axis.com>

* linux-crisv32-low.c (elf_gregset_t): Delete typedef.
(initialize_low_arch): Call init_registers_crisv32 rather than
init_register_crisv32.

diff --git a/gdb/gdbserver/linux-crisv32-low.c b/gdb/gdbserver/linux-crisv32-low.c
index efe50a7..2849d02 100644
--- a/gdb/gdbserver/linux-crisv32-low.c
+++ b/gdb/gdbserver/linux-crisv32-low.c
@@ -369,8 +369,6 @@ cris_arch_setup (void)
current_process ()->tdesc = tdesc_crisv32;
}

-typedef unsigned long elf_gregset_t[cris_num_regs];
-
static struct regset_info cris_regsets[] = {
{ PTRACE_GETREGS, PTRACE_SETREGS, 0, cris_num_regs * 4,
GENERAL_REGS, cris_fill_gregset, cris_store_gregset },
@@ -426,7 +424,7 @@ struct linux_target_ops the_low_target = {
void
initialize_low_arch (void)
{
- init_register_crisv32 ();
+ init_registers_crisv32 ();

initialize_regsets_info (&cris_regsets_info);