Re: [PATCH] Fix CRISv32 compilation

Pedro Alves
2013-09-03T12:03:53Z

On 09/03/2013 08:45 AM, Ricard Wanderlof wrote:
>
> On Mon, 2 Sep 2013, Pedro Alves wrote:
>
>> On 08/30/2013 02:12 PM, Ricard Wanderlof wrote:
>>>
>>> 2013-08-30 Ricard Wanderlof <ricardw@axis.com>
>>>
>>> gdbserver
>>>
>>> * linux-crisv32-low.c: Fix compilation errors.
>>
>> Write:
>>
>> * linux-crisv32-low.c (elf_gregset_t): Delete typedef.
>> (initialize_low_arch): Call init_registers_crisv32 rather than
>> init_register_crisv32.
>>
>> OK with that change.
>
> Ok with me. Thanks for the update. Should I resubmit the patch ?

If there were no changes since the previous post, we just check
it in (and usually reply back saying so). If the patch was approved
with changes, we commit, and reply back saying "this is what I
checked in", showing the final version. Ultimately, what this means
is we always post final version of the patch to the mailing list,
exactly as it went in.

>> (I can't see how the typedef was breaking the build though)
>
> With the typedef left in, I get

...

> when building gdbserver using the target compiler.

Thanks, that's the sort of info that's helpful to have the
in the patch rationale (which ideally ends up in the
commit log).

--
Pedro Alves