Re: [PATCH 2/2][CRIS/CRISv32] Consistent names for cris/crisv32_elf_greg_t

Ricard Wanderlof
2013-09-03T15:17:19Z

On Tue, 3 Sep 2013, Pedro Alves wrote:

> On 09/03/2013 03:17 PM, Ricard Wanderlof wrote:
>>
>> This is just a cosmetic change to get consistent names for
>> elf_greg_t/crisv32_elf_greg_t in cris-tdep.c . Compile-time tested, then
>> tested the result by running the resulting gdb against gdbserver running
>> on a target system.
>
> Thanks. It'll allow putting these types in a header too, if
> ever necessary (otherwise, they'd possibly conflict with
> asm/elf.h, like in the gdbserver patch).
>
>> 2013-09-03 Ricard Wanderlof <ricardw@axis.com>
>>
>> * cris-tdep.c (cris_elf_greg_t): Rename from elf_greg_t.
>
> Mention cris_elf_gregset_t, crisv32_elf_gregset_t, and all
> the functions that were adjusted. E.g.:
>
> * cris-tdep.c (cris_elf_greg_t): Rename from elf_greg_t.
> (cris_elf_gregset_t): Rename from elf_gregset_t.
> (crisv32_elf_gregset_t): Adjust.
> (cris_supply_gregset, fetch_core_registers): Adjust.
>
> OK with that change.

Fine by me.