From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29882 invoked by alias); 3 Dec 2014 21:00:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29861 invoked by uid 89); 3 Dec 2014 21:00:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Dec 2014 21:00:10 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XwH1p-0004ip-R5 from Maciej_Rozycki@mentor.com ; Wed, 03 Dec 2014 13:00:06 -0800 Received: from localhost (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.3.181.6; Wed, 3 Dec 2014 21:00:04 +0000 Date: Wed, 03 Dec 2014 21:00:00 -0000 From: "Maciej W. Rozycki" To: Joel Brobecker CC: , Mark Kettenis Subject: Re: [PATCH] microMIPS support (Linux signal trampolines) In-Reply-To: <20141116085801.GA8336@adacore.com> Message-ID: References: <201205182225.q4IMPBiD031110@glazunov.sibelius.xs4all.nl> <20141116085801.GA8336@adacore.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-12/txt/msg00075.txt.bz2 On Sun, 16 Nov 2014, Joel Brobecker wrote: > > gdb/ > > * tramp-frame.h (tramp_frame): Add validate member. > > * tramp-frame.c (tramp_frame_start): Validate trampoline before > > scanning. > > * mips-linux-tdep.c (MICROMIPS_INST_LI_V0): New macro. > > (MICROMIPS_INST_POOL32A, MICROMIPS_INST_SYSCALL): Likewise. > > (mips_linux_o32_sigframe): Initialize validate member. > > (mips_linux_o32_rt_sigframe): Likewise. > > (mips_linux_n32_rt_sigframe): Likewise. > > (mips_linux_n64_rt_sigframe): Likewise. > > (micromips_linux_o32_sigframe): New variable. > > (micromips_linux_o32_rt_sigframe): Likewise. > > (micromips_linux_n32_rt_sigframe): Likewise. > > (micromips_linux_n64_rt_sigframe): Likewise. > > (mips_linux_o32_sigframe_init): Handle microMIPS trampolines. > > (mips_linux_n32n64_sigframe_init): Likewise. > > (mips_linux_sigframe_validate): New function. > > (micromips_linux_sigframe_validate): Likewise. > > (mips_linux_init_abi): Install microMIPS trampoline unwinders. > > Sorry again for the late review, Maciej. No worries, better late than never, and I contributed to the delay in the first place, by keeping it all aside for two years or so. > This patch is pre-approved, with one tiny little request: > Can you add a quick one-liner comment as documentation for > all the new functions? For instance: > > /* Implement struct tramp_frame's "validate" method for [...] */ > > static int > mips_linux_sigframe_validate (const struct tramp_frame *self, Done now, for the above and `micromips_linux_sigframe_validate' too. I fixed a minor formatting issue with `micromips_linux_o32_rt_sigframe' as well. I have committed the change now; I think the updates are too insignificant to justify reposting the final version, just check the repository if curious. Thanks for your review. Maciej