Re: [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests

Doug Evans
2014-11-16T18:32:26Z

On Sun, Nov 16, 2014 at 3:09 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S
>> ===================================================================
>> --- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S 2014-10-02 07:56:23.000000000 +0100
>> +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S 2014-10-02 07:58:10.978958268 +0100
>> @@ -15,7 +15,8 @@
>>
>> .text
>> .globl main
>> -main: .byte 0
>> +main:
>> + .dc.l 0
>
> We've never used .dl.l before, and I don't know how widely available
> it is (in fact, I couldn't find it in the GAS manual). How about using
> .word or .4byte? It would also be consistent with what we've usually be
> using. Would that work?

Agreed.