From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, James Hogan <james.hogan@imgtec.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] MIPS: Ignore invalid regs during info registers all
Date: Fri, 03 Oct 2014 16:32:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1410031728470.19130@tp.orcam.me.uk> (raw)
In-Reply-To: <542ACDDB.2080202@redhat.com>
On Tue, 30 Sep 2014, Pedro Alves wrote:
> >>> The "info registers all" command causes mips_print_registers_info () to be
> >>> called for all register numbers, including invalid ones such as unused DSP
> >>> register numbers. This triggers an error () call which prevents further
> >>> register values being printed. Just silently return without printing
> >>> anything or erroring, so that all valid registers can be printed.
> >>
> >> What happens when the user does "info registers that-unused-register" ?
> >
> > I don't think that's possible, because the check is:
> > if (*(gdbarch_register_name (gdbarch, regnum)) == '\0')
> >
> > So any such register already has no name by which to refer to it.
>
> Indeed. :-) I'll leave it to Maciej to approve.
I didn't know `info registers' (and `info all-registers' presumably as
well) supported further arguments; I'll experiment with the patch a bit
and see what comes out.
James, did you push your change through regression testing? If so, then
how? Please always state precisely how changes you submit have been
validated.
Maciej
prev parent reply other threads:[~2014-10-03 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 14:43 James Hogan
2014-09-30 15:01 ` Pedro Alves
2014-09-30 15:05 ` James Hogan
2014-09-30 15:36 ` Pedro Alves
2014-10-03 16:32 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1410031728470.19130@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=james.hogan@imgtec.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox