From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: <gdb-patches@sourceware.org>, <green@moxielogic.com>,
Yao Qi <yao@codesourcery.com>
Subject: Re: [PATCH] Remove some obfuscation from ${arch}_skip_prologue functions
Date: Thu, 04 Sep 2014 17:51:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1409041840360.27075@tp.orcam.me.uk> (raw)
In-Reply-To: <yjt2y4u1pokj.fsf@ruffy.mtv.corp.google.com>
On Wed, 3 Sep 2014, Doug Evans wrote:
> Can I enlist any of the other arch maintainers to regression test this
> there: lm32, mips, arm, nios2, tic6x, tilegx, avr, moxie, sh?
Thanks for working on these clean-ups.
I'll try to push this through testing; what makes me curious about is
whether there's a hidden trap here for compressed ISAs (i.e. MIPS16 and
microMIPS code) where the value of the PC is not the same as the memory
address of the instruction being accessed (the LSB or the ISA bit in the
PC is forcefully set to 1). Another matter may be various MIPS16 call
thunks. I have a vague recollection of my previous encounters with this
code, but it was so many years ago I may have troubles bringing back what
it really was, unless I am able to track down some patches.
One issue here is not every possible execution path is covered in
regression testing, some of the issues in places like this only happen in
situations that are difficult to transform into a proper GDB test case
(and e.g. our MIPS16 thunk tests remain non-functional with stock GCC
because of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53276).
Maciej
prev parent reply other threads:[~2014-09-04 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 23:53 Doug Evans
2014-09-03 17:19 ` Doug Evans
2014-09-04 8:59 ` Yao Qi
2014-09-04 17:42 ` Doug Evans
2014-09-09 1:29 ` Yao Qi
2014-09-04 17:51 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1409041840360.27075@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=green@moxielogic.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox