From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4257 invoked by alias); 3 Sep 2014 21:21:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4239 invoked by uid 89); 3 Sep 2014 21:21:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Sep 2014 21:21:40 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XPHzh-0002dZ-3h from Maciej_Rozycki@mentor.com ; Wed, 03 Sep 2014 14:21:35 -0700 Received: from localhost (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Wed, 3 Sep 2014 22:21:30 +0100 Date: Wed, 03 Sep 2014 21:21:00 -0000 From: "Maciej W. Rozycki" To: James Hogan CC: Subject: Re: [PATCH v2] Reset errno before PTRACE_PEEKUSER for MIPS DSP_CONTROL In-Reply-To: <20140903125111.GF12084@jhogan-linux.le.imgtec.org> Message-ID: References: <1409608120-23991-1-git-send-email-james.hogan@imgtec.com> <20140903125111.GF12084@jhogan-linux.le.imgtec.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-09/txt/msg00104.txt.bz2 On Wed, 3 Sep 2014, James Hogan wrote: > > > gdb/: > > > * mips-linux-nat.c (mips_linux_read_description): Reset errno to 0 > > > prior to reading DSP_CONTROL with PTRACE_PEEKUSER ptrace call. > > > > > > gdb/gdbserver/: > > > * linux-mips-low.c (mips_read_description): Reset errno to 0 prior > > > to reading DSP_CONTROL with PTRACE_PEEKUSER ptrace call. > > > > This is fine, go ahead and apply it. Thanks. > > Thanks for reviewing it Maciej. > > This is my first GDB patch submitted upstream (although I have a pile of > RFC patches for FR=1, FRE=1, MSA support I'm still getting into shape), > so I don't have push access yet. Is it easy to arrange? Sure, that can be arranged, but you need to prove yourself by submitting a few more good patches first though. And assuming you've got a copyright assignment in place with FSF, either personally or on behalf of your employer (I presume you do, but please confirm as you start sending larger changes). You'll have to speak with one of the general maintainers when the right time comes. I have applied your change now, thanks. BTW, I've had some FR=1 stuff ongoing too, though regrettably stalled recently, see: https://sourceware.org/bugzilla/show_bug.cgi?id=7518 http://sourceware.org/ml/gdb-patches/2012-06/msg00201.html -- based on an old patch from MIPS Technologies that wasn't quite there, but still was a good starting point. Bare iron only of course as there was no FR=1 Linux ABI up until recently. It will be interesting to see how the two pieces compare. Or actually it may make sense if I push my piece first, there was just some concern about regcache that remained unresolved, so I'll see if I can reintegrate that change against current trunk, retest and repost. Maciej