From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: James Hogan <james.hogan@imgtec.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Reset errno before PTRACE_PEEKUSER for MIPS DSP_CONTROL
Date: Wed, 03 Sep 2014 12:41:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1409031340130.27075@tp.orcam.me.uk> (raw)
In-Reply-To: <1409608120-23991-1-git-send-email-james.hogan@imgtec.com>
On Mon, 1 Sep 2014, James Hogan wrote:
> PTRACE_PEEKUSER can return -1, which is usually used to determine whether
> a system call has reported an error, so errno must be used alone to
> determine whether an error occurred. However errno isn't modified by a
> successful system call so it must be reset to a known value (0) before the
> syscall call.
>
> Add the missing errno reset when reading the DSP_CONTROL register in the
> native MIPS Linux backend and the MIPS gdbserver backend.
>
> gdb/:
> * mips-linux-nat.c (mips_linux_read_description): Reset errno to 0
> prior to reading DSP_CONTROL with PTRACE_PEEKUSER ptrace call.
>
> gdb/gdbserver/:
> * linux-mips-low.c (mips_read_description): Reset errno to 0 prior
> to reading DSP_CONTROL with PTRACE_PEEKUSER ptrace call.
This is fine, go ahead and apply it. Thanks.
Maciej
next prev parent reply other threads:[~2014-09-03 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 21:48 James Hogan
2014-09-03 12:41 ` Maciej W. Rozycki [this message]
2014-09-03 12:51 ` James Hogan
2014-09-03 21:21 ` Maciej W. Rozycki
2014-09-17 16:22 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1409031340130.27075@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=james.hogan@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox