From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: Gary Benson <gbenson@redhat.com>, <gdb-patches@sourceware.org>,
Tom Tromey <tromey@redhat.com>, Doug Evans <dje@google.com>
Subject: Re: [PATCH 03/15 v2] Make gdbserver CORE_ADDR unsigned
Date: Fri, 18 Jul 2014 08:07:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1407172344220.16254@tp.orcam.me.uk> (raw)
In-Reply-To: <53C7FCB1.4060904@redhat.com>
On Thu, 17 Jul 2014, Pedro Alves wrote:
> The only issue that I think might come out of this is
> that on MIPS, addresses are signed, so pointers are sign
> extended. But we can definitely handle whatever fallout this
> may cause, if any, when we see it. Clearly if GDB's native
> targets can handle that, so should gdbserver's, and in any
> case the issue should be pretty localized. Just pointing it
> out FYI, to keep an eye out for it.
Also SH64 AFAICT, it defines `elf_backend_sign_extend_vma' to true in
bfd/elf32-sh64.c. We have the following comment in gdb/mips-tdep.c:
/* MIPS believes that the PC has a sign extended value. Perhaps the
all registers should be sign extended for simplicity? */
which is of course true in that we need to sign-extend all integer
registers (that includes GPRs and CP0 registers; maybe some control
registers as well); where applicable that is, i.e. debugging a strict
32-bit ABI on 64-bit hardware. Then on the other hand the values in these
registers should already have been truncated to 32 bits and then
sign-extended before they have been written in the first place.
Overall it's tricky, hardware does not always enforce proper
sign-extension required by the ABI, e.g. an o32 kernel-mode program is
free to set GPRs or the PC to a value outside the range supported by the
ABI (the Linux kernel sometimes takes advantage of this possibility), and
we have no way I believe to make the user aware of this happening, while
that might be The Bug they're after.
Maciej
next prev parent reply other threads:[~2014-07-17 23:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 16:19 [PATCH 00/15 v2] Common code cleanups Gary Benson
2014-07-16 16:19 ` [PATCH 04/15 v2] Introduce common-types.h Gary Benson
2014-07-17 11:21 ` Doug Evans
2014-07-16 16:19 ` [PATCH 15/15 v2] Finally remove GDBSERVER (mostly) from linux-btrace.c Gary Benson
2014-07-16 16:32 ` [PATCH 09/15 v2] Mostly remove GDBSERVER from linux-waitpid.c Gary Benson
2014-07-16 16:33 ` [PATCH 14/15 v2] Introduce get_thread_regcache_for_ptid Gary Benson
2014-07-16 16:45 ` [PATCH 01/15 v2] Introduce common/errors.h Gary Benson
2014-07-16 18:36 ` Doug Evans
2014-07-17 13:41 ` [PATCH] " Gary Benson
2014-07-17 13:47 ` Gary Benson
2014-07-17 14:05 ` [PATCH 01/15 v3] " Gary Benson
2014-07-17 15:40 ` Pedro Alves
2014-07-17 16:03 ` Gary Benson
2014-07-17 16:19 ` Pedro Alves
2014-07-18 9:20 ` Gary Benson
2014-07-18 10:42 ` Doug Evans
2014-07-18 11:23 ` Gary Benson
2014-07-18 12:31 ` Doug Evans
2014-07-18 10:44 ` Pedro Alves
2014-07-16 16:45 ` [PATCH 02/15 v2] Remove some GDBSERVER checks from linux-ptrace Gary Benson
2014-07-17 8:37 ` Doug Evans
2014-07-17 16:40 ` Pedro Alves
2014-07-16 16:45 ` [PATCH 05/15 v2] Introduce and use debug_printf and debug_vprintf Gary Benson
2014-07-16 16:48 ` [PATCH 03/15 v2] Make gdbserver CORE_ADDR unsigned Gary Benson
2014-07-17 9:02 ` Doug Evans
2014-07-17 16:42 ` Pedro Alves
2014-07-18 8:07 ` Maciej W. Rozycki [this message]
2014-07-16 16:48 ` [PATCH 06/15 v2] Remove simple GDBSERVER uses from common, nat and target Gary Benson
2014-07-16 17:03 ` [PATCH 08/15 v2] Make btrace-common.h not use GDBSERVER Gary Benson
2014-07-16 17:03 ` [PATCH 13/15 v2] Finally remove GDBSERVER (mostly) from agent.c Gary Benson
2014-07-16 17:03 ` [PATCH 11/15 v2] More target unification Gary Benson
2014-07-16 17:04 ` [PATCH 10/15 v2] Add target/target.h Gary Benson
2014-07-16 17:20 ` [PATCH 12/15 v2] Add target/symbol.h, update users Gary Benson
2014-07-16 17:24 ` [PATCH 07/15 v2] Remove GDBSERVER use from nat/i386-dregs.c Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1407172344220.16254@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=dje@google.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox