Re: [PING][PATCH] GDB/testsuite: Add a way to send multiple init commands

Eli Zaretskii
2014-06-20T07:14:47Z

> Date: Fri, 20 Jun 2014 00:39:32 +0100
> From: "Maciej W. Rozycki" <macro@codesourcery.com>
> CC: Keith Seitz <keiths@redhat.com>, Eli Zaretskii <eliz@gnu.org>, <gdb-patches@sourceware.org>
>
> On Wed, 11 Jun 2014, Maciej W. Rozycki wrote:
>
> > On Wed, 11 Jun 2014, Tom Tromey wrote:
> >
> > > Maciej> 2014-06-10 Maciej W. Rozycki <macro@mips.com>
> > > Maciej> Maciej W. Rozycki <macro@codesourcery.com>
> > >
> > > Maciej> * lib/gdb.exp (gdb_run_cmd): Process `gdb_init_commands'.
> > > Maciej> * lib/mi-support.exp (mi_run_cmd): Process `gdb_init_commands'.
> > >
> > > I like Keith's proposed cleanup.
> > >
> > > Maciej> + set commands [target_info gdb_init_commands];
> > >
> > > Extraneous ";". There are a few of these.
> >
> > Sigh, it just shows my lack of experience with TCL back in 2005. I've
> > been pondering an update to the change to avoid some code duplication, so
> > given I had to touch it anyway I went ahead and did it. Here's the
> > result.
> >
> > It has been lightly tested with gdb.base/advance.exp, with neither
> > setting defined, with `gdb_init_command' only, with `gdb_init_commands'
> > only having a single element, with `gdb_init_commands' only having two
> > elements and with both `gdb_init_command' and `gdb_init_commands' defined,
> > the latter having two elements. It has been also smoke-tested with
> > gdb.mi/mi-break.exp, with the last arrangement mentioned above only.
> >
> > > I think this patch should also update testsuite/README to document the
> > > new setting.
> >
> > And presumably the old one as well, right? Cc-ing Eli for this part.
> >
> > 2014-06-11 Maciej W. Rozycki <macro@mips.com>
> > Maciej W. Rozycki <macro@codesourcery.com>
> >
> > * lib/gdb.exp (gdb_run_cmd): Process `gdb_init_commands'.
> > * lib/mi-support.exp (mi_run_cmd): Process `gdb_init_commands'.
> > * README (Board Settings): Document `gdb_init_command' and
> > `gdb_init_commands'.
>
> Ping.

Not sure why I'm one of the addressees: there's no documentation in
this patch.