From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17270 invoked by alias); 28 Nov 2013 16:18:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17257 invoked by uid 89); 28 Nov 2013 16:18:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Nov 2013 16:18:26 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Vm4I5-0007YZ-QS from Maciej_Rozycki@mentor.com ; Thu, 28 Nov 2013 08:18:09 -0800 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 28 Nov 2013 08:18:09 -0800 Received: from [172.30.64.195] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.2.247.3; Thu, 28 Nov 2013 16:18:08 +0000 Date: Thu, 28 Nov 2013 17:38:00 -0000 From: "Maciej W. Rozycki" To: Hui Zhu CC: Pedro Alves , gdb-patches ml Subject: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet In-Reply-To: <529707C7.4040504@mentor.com> Message-ID: References: <5265022F.8060203@mentor.com> <52654A2C.9010202@redhat.com> <529707C7.4040504@mentor.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-11/txt/msg00884.txt.bz2 On Thu, 28 Nov 2013, Hui Zhu wrote: > According to your comments. I make a new patch for it. > It add a check in remote_insert_breakpoint. If this breakpoint have target > breakpoint but it is not handled by "Z" packet, function will return error. > > Please help me review it. > > Because mi-dprintf.exp and dprintf.exp use "set dprintf-style agent" check if > target support target-side breakpoint, they are still got fail after this > patch. > If you think this patch's idea is OK, I will make patch for them. > > Thanks, > Hui > > 2013-11-28 Hui Zhu > > * remote.c (remote_insert_breakpoint): Add > have_target_target_side_commands. Please note that this is PR gdb/16101 now and refer to it in the ChangeLog entry. Maciej