From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18301 invoked by alias); 25 Jul 2013 21:17:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18276 invoked by uid 89); 25 Jul 2013 21:17:57 -0000 X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_50,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 25 Jul 2013 21:17:56 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1V2Suy-0004eZ-RF from Maciej_Rozycki@mentor.com for gdb-patches@sourceware.org; Thu, 25 Jul 2013 14:17:48 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 25 Jul 2013 14:17:48 -0700 Received: from [172.30.64.136] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Thu, 25 Jul 2013 22:17:46 +0100 Date: Thu, 25 Jul 2013 21:17:00 -0000 From: "Maciej W. Rozycki" To: Yao Qi CC: Subject: Re: [PATCH 4/5] Move mips hardware watchpoint stuff to common/ In-Reply-To: <51F06C10.5060905@codesourcery.com> Message-ID: References: <1369881867-11372-1-git-send-email-yao@codesourcery.com> <1372475427-24862-1-git-send-email-yao@codesourcery.com> <1372475427-24862-5-git-send-email-yao@codesourcery.com> <51F06C10.5060905@codesourcery.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-07/txt/msg00630.txt.bz2 On Thu, 25 Jul 2013, Yao Qi wrote: > OK, I keep inclusion in the updated patch > below. The functions order is fixed in the updated patch > too. Thanks. This shows the following changes that you made in the process of moving the functions across. They are fine with me, but I prefer to have them included with 3/5 where changes are supposed to be made, so please move them there. --- gdb/mips-linux-nat.c~ 2013-07-25 17:15:17.318692194 +0100 +++ gdb/common/mips-linux-watch.c 2013-07-25 17:15:32.318690373 +0100 @@ -627,10 +90,10 @@ mips_linux_watch_get_watchlo (struct pt_ } } -/* Assuming usable watch registers REGS, set VALUE to watchlo of +/* Assuming usable watch registers REGS, set a watchlo VALUE of register N. */ [...] @@ -668,10 +131,10 @@ mips_linux_watch_get_watchhi (struct pt_ } } -/* Assuming usable watch registers REGS, set VALUE to watchhi of +/* Assuming usable watch registers REGS, set a watchhi VALUE of register N. */ [...] fill_mask (CORE_ADDR mask) { CORE_ADDR f = 1; + while (f && f < mask) { mask |= f; OK with this change, thanks. [The wording of the function descriptions is a bit unfortunate, but that's a preexisting problem, so you don't need to do anything about them unless you want to (e.g. "[...] set watchlo of register N to VALUE." would be better).] Maciej