From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6145 invoked by alias); 24 Jul 2013 00:26:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6123 invoked by uid 89); 24 Jul 2013 00:26:15 -0000 X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_50,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 24 Jul 2013 00:26:14 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1V1mu7-000643-7T from Maciej_Rozycki@mentor.com for gdb-patches@sourceware.org; Tue, 23 Jul 2013 17:26:07 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 23 Jul 2013 17:26:06 -0700 Received: from [172.30.64.136] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.2.247.3; Wed, 24 Jul 2013 01:26:05 +0100 Date: Wed, 24 Jul 2013 00:26:00 -0000 From: "Maciej W. Rozycki" To: Yao Qi CC: Subject: Re: [PATCH 1/5] Share 'enum target_hw_bp_type' in GDB and GDBserver. In-Reply-To: <1372475427-24862-2-git-send-email-yao@codesourcery.com> Message-ID: References: <1369881867-11372-1-git-send-email-yao@codesourcery.com> <1372475427-24862-1-git-send-email-yao@codesourcery.com> <1372475427-24862-2-git-send-email-yao@codesourcery.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-07/txt/msg00549.txt.bz2 On Sat, 29 Jun 2013, Yao Qi wrote: > 'enum target_hw_bp_type' has been used in both GDB and GDBserver. It > will be used in MIPS hardware watchpoint support too. This patch > is to share 'enum target_hw_bp_type' in common/break-common.h. FWIW this patch looks reasonable to me, though I can't approve or reject a generic change like this. I can see gdb/gdbserver/linux-aarch64-low.c has a similar target_point_type enum. It might be a good idea to unify them all. Maciej