From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103411-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30974 invoked by alias); 15 Jul 2013 15:55:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30941 invoked by uid 89); 15 Jul 2013 15:55:08 -0000
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_40,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,TW_FX autolearn=no version=3.3.1
X-Spam-User: qpsmtpd, 2 recipients
Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 15 Jul 2013 15:55:07 +0000
Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93])	by relay1.mentorg.com with esmtp 	id 1Uyl75-0002iC-Qz from Maciej_Rozycki@mentor.com ; Mon, 15 Jul 2013 08:54:59 -0700
Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);	 Mon, 15 Jul 2013 08:54:59 -0700
Received: from [172.30.64.18] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Mon, 15 Jul 2013 16:54:57 +0100
Date: Mon, 15 Jul 2013 15:55:00 -0000
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Richard Sandiford <rdsandiford@googlemail.com>
CC: <binutils@sourceware.org>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] MIPS: Define descriptive names for GNU attribute values
In-Reply-To: <8761we3owq.fsf@talisman.default>
Message-ID: <alpine.DEB.1.10.1307151654340.20590@tp.orcam.me.uk>
References: <alpine.DEB.1.10.1307121705400.20590@tp.orcam.me.uk> <8761we3owq.fsf@talisman.default>
User-Agent: Alpine 1.10 (DEB 962 2008-03-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-SW-Source: 2013-07/txt/msg00351.txt.bz2

On Sat, 13 Jul 2013, Richard Sandiford wrote:

> > 	include/elf/
> > 	* mips.h (Tag_GNU_MIPS_ABI_FP): Remove comment.
> > 	(Val_GNU_MIPS_ABI_FP_ANY, Val_GNU_MIPS_ABI_FP_DOUBLE,
> > 	Val_GNU_MIPS_ABI_FP_SINGLE, Val_GNU_MIPS_ABI_FP_SOFT,
> > 	Val_GNU_MIPS_ABI_FP_64): New enum.
> >
> > 	bfd/
> > 	* elfxx-mips.c (mips_elf_merge_obj_attributes): Replace hardcoded
> > 	magic numbers with enum values.
> >
> > 	binutils/
> > 	* readelf.c (display_mips_gnu_attribute): Replace hardcoded magic
> > 	numbers with enum values.
> >
> > 	gdb/
> > 	* mips-tdep.c (mips_gdbarch_init): Replace hardcoded magic
> > 	numbers with enum values.
> 
> OK.  Nice cleanup, thanks.

 Committed now, thanks.

  Maciej