From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18195 invoked by alias); 17 May 2012 15:07:10 -0000 Received: (qmail 18180 invoked by uid 22791); 17 May 2012 15:07:09 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 May 2012 15:06:50 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SV2Hx-0000r1-4I from Maciej_Rozycki@mentor.com ; Thu, 17 May 2012 08:06:49 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 17 May 2012 08:06:32 -0700 Received: from [172.30.0.201] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Thu, 17 May 2012 16:06:47 +0100 Date: Thu, 17 May 2012 15:07:00 -0000 From: "Maciej W. Rozycki" To: Eli Zaretskii CC: Subject: Re: [PATCH] microMIPS support In-Reply-To: <83k40usfjk.fsf@gnu.org> Message-ID: References: <83k414fjmp.fsf@gnu.org> <83haw6io8k.fsf@gnu.org> <8362cmi65h.fsf@gnu.org> <83y5ph6nqj.fsf@gnu.org> <83k40usfjk.fsf@gnu.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00653.txt.bz2 On Wed, 2 May 2012, Eli Zaretskii wrote: > > gdb/doc/gdb.texinfo:36670: `MIPS Breakpoint Kinds' has no Up field (perhaps incorrect sectioning?). > > > > if I add a lone @node definition, or that plus: > > > > gdb/doc/gdb.texinfo:36670: warning: unreferenced node `MIPS Breakpoint Kinds'. > > > > if I place a @menu reference to that node in any of the upper sections. > > That's most probably because you added only some of the menus, not all > of them. The minor variation of your patch below doesn't have this > problem, it produces an Info manual without any warnings or errors. I added only some of the menus by your explicit request. You rejected my proposal that I made in response which added all of them and that was only trivially different to the version you have proposed now. > > I'll be pushing it in this form as soon as the MIPS16 manual > > function call change has been committed. > > I believe committing a patch over objections of the responsible > maintainer is against the rules described in MAINTAINERS (as I > understand them). So please don't do that. Certainly, next time I'll just drop any changes to the manual I disagree with. > Please use the slightly modified patch below instead. Thanks for your proposal, even though my original concern about pages containing single-entry menus still stands. This doesn't really matter however for two reasons, first and foremost because you have the power to override my objection to any changes to the manual, and second because it contains changes irrelevant to my change and as such I cannot integrate them. Please split changes to the existing pieces of the manual off and commit them separately. I'll extract the rest and fold into my change. I'll be doing the final round of testing of the microMIPS feature now, now that I made a final adjustment that I found necessary after investigation related to some changes I posted more recently. I want to push the microMIPS change by the end of tomorrow at the latest. > (After you install your patch, I will follow up with a patch that > changes all occurrences of "MIPS" to use @acronym. I already have > that patch ready on my box.) I appreciate your effort. Thank you. Maciej