From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA/commit] procfs.c: Remove unused functions and make many functions static
Date: Mon, 07 May 2012 08:24:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1205070913570.18334@tp.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.1.10.1205042344220.18334@tp.orcam.me.uk>
On Fri, 4 May 2012, Maciej W. Rozycki wrote:
> > Even if the initial intention was to provide an API, I do not think
> > it's a good idea to keep maintaining dead code. Making functions
> > static is often a big help in figuring out the potential call sites
> > (you immediately know that you do not have to grep the entire repo).
>
> I agree, I just raised my point for the avoidance of doubt. Also we have
> a public repository these days where individual changes can be reasonably
> easy to track for any code to resurrect if needed -- something that GDB
> certainly did not have back in 1991.
Hmm, here's a dumb question as a followup, following a situation I've
just experienced -- can this stuff be needed by anything external on
Solaris, similarly to some functions pulled from GDB by libthread_db.so.1
from glibc?
Maciej
next prev parent reply other threads:[~2012-05-07 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 23:15 Joel Brobecker
2012-05-04 9:10 ` Maciej W. Rozycki
2012-05-04 12:35 ` Joel Brobecker
2012-05-04 22:49 ` Maciej W. Rozycki
2012-05-07 8:24 ` Maciej W. Rozycki [this message]
2012-05-17 17:35 ` Joel Brobecker
2012-05-17 19:26 ` Maciej W. Rozycki
2012-05-17 20:43 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1205070913570.18334@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox